From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer Date: Sat, 08 Apr 2023 21:36:30 +0300 Organization: LINKOV.NET Message-ID: <86ttxqdwyp.fsf@mail.linkov.net> References: <864jpsrgaz.fsf@mail.linkov.net> <86h6tr4pi8.fsf@mail.linkov.net> <87sfdbmmmh.fsf@catern.com> <838rf2opa0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62700@debbugs.gnu.org, sbaugh@catern.com, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 08 21:04:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plDrM-0008k7-PP for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Apr 2023 21:04:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plDr2-0000Ht-Fw; Sat, 08 Apr 2023 15:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plDr0-00008u-Rv for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 15:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plDr0-0001I4-I4 for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 15:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plDr0-0007Kw-5G for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 15:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62700 X-GNU-PR-Package: emacs Original-Received: via spool by 62700-submit@debbugs.gnu.org id=B62700.168098060428143 (code B ref 62700); Sat, 08 Apr 2023 19:04:02 +0000 Original-Received: (at 62700) by debbugs.gnu.org; 8 Apr 2023 19:03:24 +0000 Original-Received: from localhost ([127.0.0.1]:59541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plDqO-0007Jr-5g for submit@debbugs.gnu.org; Sat, 08 Apr 2023 15:03:24 -0400 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:50003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plDqM-0007JP-8W for 62700@debbugs.gnu.org; Sat, 08 Apr 2023 15:03:22 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 92C11240002; Sat, 8 Apr 2023 19:03:14 +0000 (UTC) In-Reply-To: <838rf2opa0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Apr 2023 09:34:47 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259490 Archived-At: >> > Changing the API will definitely cause problems with backwards-compatibility. >> > But maybe you could find a simple heuristic that would decide what base-suffix >> > to set in minibuffer-completion-help? Then no API changes will be needed. >> >> Thank you for the guidance and suggestion. >> >> Here's one heuristic which works decently well: > > If this is for master, I'm fine with such changes. But if you intend > to request installing this on emacs-29, then I will object making > non-trivial changes in any code that is not specific to the M- and Actually, a change for base-suffix in minibuffer-completion-help is a trivial change. What counts as a non-trivial change would be changing the API in completion-all-completions. > M- bindings that are new in Emacs 29. I don't want to risk any > regressions in general-purpose completion code at this late stage. These changes are specific to the M- and M- bindings: completion-use-base-affixes is nil, and it's let-bound to t in M- (minibuffer-previous-completion) and M- (minibuffer-next-completion).