unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Oleksandr Gavenko <gavenkoa@gmail.com>
Cc: Dmitry Gutov <dmitry@gutov.dev>, 62749@debbugs.gnu.org
Subject: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer
Date: Mon, 15 May 2023 19:46:36 +0300	[thread overview]
Message-ID: <86ttwdlffv.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAFNJpnjy=LjSyXQOrvfFgsut5SnyF1S-ruOqdpq8bN+jRXUfBg@mail.gmail.com> (Oleksandr Gavenko's message of "Sun, 14 May 2023 13:59:49 +0300")

> After bisecting my long .emacs config I pinpointed the culprit:
>
> (which-func-mode 1)
>
> During the movement through a diff buffer this mode loads corresponding
> files:
>
>   if the cursor reaches a new hunk - the corresponding file is opened ((
>
> This is done one by one file while I scroll down with the cursor.
>
> Removing the line significantly improved performance during scromming in VC
> diff buffer in Cygwin and no more new files opened!

This is an interesting problem, I can reproduce it by
'M-x which-function-mode'.

> I think which-function-mode is broken for diff-mode, the workaround for
> those who wants this mode is to deal with:
>
> (defcustom which-func-modes t
>   ;; '(emacs-lisp-mode c-mode c++-mode objc-mode perl-mode cperl-mode python-mode
>   ;;               makefile-mode sh-mode fortran-mode f90-mode ada-mode
>   ;;               diff-mode)
>   "List of major modes for which Which Function mode should be used.
> For other modes it is disabled.  If this is equal to t,
> then Which Function mode is enabled in any major mode that supports it."
>
> What are the next actions?

Maybe 'diff-syntax-fontify' could have a similar list of minor modes
that should be ignored.  Then such a list should at least contain
'which-func-mode' by default.





  reply	other threads:[~2023-05-15 16:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 12:11 bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer Oleksandr Gavenko
2023-04-10 12:14 ` Oleksandr Gavenko
2023-04-10 22:23 ` Dmitry Gutov
2023-05-14 10:59   ` Oleksandr Gavenko
2023-05-15 16:46     ` Juri Linkov [this message]
2023-05-16 11:46       ` Dmitry Gutov
2023-05-16 16:44         ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ttwdlffv.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=62749@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=gavenkoa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).