From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62032: 28.2; `switch-frame' event exits incremental search Date: Wed, 17 May 2023 19:30:50 +0300 Organization: LINKOV.NET Message-ID: <86ttwaor7p.fsf@mail.linkov.net> References: <4941298cd70a4be0a12aa64013b0a4de@vodafonemail.de> <83wn3s6658.fsf@gnu.org> <86356gxvwk.fsf@mail.linkov.net> <49cd9a41-d634-183d-262a-373688329818@vodafonemail.de> <04047c45-206c-8e41-42d9-4c62e49b0496@vodafonemail.de> <865ybas6rx.fsf@mail.linkov.net> <87zg8j15nu.fsf@athena.silentflame.com> <86fsab12xt.fsf@mail.linkov.net> <465a6aca-8c55-0fa8-c083-ac1fb0dbac8a@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 62032@debbugs.gnu.org To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 17 19:20:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzKpU-0000p4-Oo for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 May 2023 19:20:48 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzKom-0004vn-W7; Wed, 17 May 2023 13:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzKok-0004v2-Hw for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 13:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzKok-0006z7-9L for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzKok-0002RJ-2Y for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62032 X-GNU-PR-Package: emacs Original-Received: via spool by 62032-submit@debbugs.gnu.org id=B62032.16843439879297 (code B ref 62032); Wed, 17 May 2023 17:20:01 +0000 Original-Received: (at 62032) by debbugs.gnu.org; 17 May 2023 17:19:47 +0000 Original-Received: from localhost ([127.0.0.1]:50863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoV-0002Pt-8J for submit@debbugs.gnu.org; Wed, 17 May 2023 13:19:47 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoT-0002Pa-Pv for 62032@debbugs.gnu.org; Wed, 17 May 2023 13:19:46 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id E60D1FF808; Wed, 17 May 2023 17:19:38 +0000 (UTC) In-Reply-To: <465a6aca-8c55-0fa8-c083-ac1fb0dbac8a@vodafonemail.de> (Jens Schmidt's message of "Tue, 16 May 2023 23:37:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261874 Archived-At: > To summarize: > > I have been confused by a misleading comment in ispell.el - frame switches > should actually exit isearch. Others have been confused as well, see > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=41338#59. > > Attached is a patch that changes the comment to avoid future confusion. I'm > still in the process of FSF copyright assignment, but the patch probably > classifies as paperwork-exempt, anyway. > > If you feel that this all not worth the hassle, you can also just close > this bug without patching anything. > > - ;; Pass frame events transparently so they won't exit the search. > - ;; In particular, if we have more than one display open, then a > - ;; switch-frame might be generated by someone typing at another keyboard. > + ;; Frame events should exit the search, because such frame events > + ;; as `switch-frame’ and `delete-frame’ change the current buffer. > + ;; See Bug#41338 for details. > (define-key map [switch-frame] nil) > (define-key map [delete-frame] nil) > (define-key map [iconify-frame] nil) Such comment could be pushed to emacs-29. Then emacs-30 hopefully will support a new feature 'isearch-buffer-local' allowing not to exit isearch after switching frames.