From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Tue, 23 May 2023 09:46:01 +0300 Organization: LINKOV.NET Message-ID: <86ttw3blc6.fsf@mail.linkov.net> References: <834jod1lvc.fsf@gnu.org> <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <63854a1a-8178-d039-288c-34b1e67e5b06@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35554"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: sbaugh@janestreet.com, Eli Zaretskii , 63469@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 23 09:05:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1M5S-00096Z-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 May 2023 09:05:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1M4y-00072d-Ll; Tue, 23 May 2023 03:05:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1M4s-00071b-AK for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 03:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1M4s-00071E-1c for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 03:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1M4r-00057K-T4 for bug-gnu-emacs@gnu.org; Tue, 23 May 2023 03:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 May 2023 07:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.168482545919593 (code B ref 63469); Tue, 23 May 2023 07:05:01 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 23 May 2023 07:04:19 +0000 Original-Received: from localhost ([127.0.0.1]:38091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1M4B-00055v-5d for submit@debbugs.gnu.org; Tue, 23 May 2023 03:04:19 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:34893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1M48-00055f-Q1 for 63469@debbugs.gnu.org; Tue, 23 May 2023 03:04:18 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 430C81C0003; Tue, 23 May 2023 07:04:08 +0000 (UTC) In-Reply-To: <63854a1a-8178-d039-288c-34b1e67e5b06@gutov.dev> (Dmitry Gutov's message of "Mon, 22 May 2023 22:59:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262206 Archived-At: >> +(define-minor-mode project-mode >> + "Toggle display of project menu in the project-aware buffers." >> + (if project-mode >> + (setq-local project-name (concat >> + " " >> + (propertize >> + (project-name (project-current)) >> + 'mouse-face 'mode-line-highlight >> + 'local-map project-mode-line-map))))) > > At the very least, this will need some better name, because project > features don't need any mode to be turned on to be used. > > project-menu-mode? 'project-mode' will be more like 'vc-mode' that actually is not a minor mode. I don't know why it was named 'vc-mode'. > Next, I'm not quite sure about the caching of project-name. There is no > scenario when it will be invalidated, right? I can't imagine such scenario. > Try simply calling (project-name (project-current t)) every time, see how > the performance is. Or, more thoroughly, copy the if-let logic from > project-prefixed-buffer-name. Ok, will try. BTW, there is another problem: by default 'project-name' is defined as (file-name-nondirectory (directory-file-name (project-root project))). But then project name often is the same for different projects because the directory name is the same for the same repository. For example, in a subtree: emacs-master/emacs/... emacs-29/emacs/... emacs-28/emacs/... All project names are the same 'emacs'. How would it be possible to customize project names? Trying to get a parent dir might be too unreliable. So probably the only way is to define the name manually. Maybe in .dir-locals.el. Actually this works: ((nil . ((project-vc-name . "emacs-29")))) Not sure why non-VC projects can't be named the same way. Also noticed that project-vc-name is not marked as safe, so always asks a confirmation.