From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#65928: [PATCH] Introduce 'project-save-buffers' Date: Fri, 15 Sep 2023 09:32:25 +0300 Organization: LINKOV.NET Message-ID: <86ttrw6l0m.fsf@mail.linkov.net> References: <86zg1ptf5x.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="878"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 65928@debbugs.gnu.org, me@elken.dev To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 08:47:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh2bv-000Aa6-3y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 08:47:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh2bS-0001O5-Pg; Fri, 15 Sep 2023 02:46:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh2bR-0001Nq-BK for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 02:46:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh2bR-0006tp-3Z for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 02:46:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh2bX-0005gY-0S for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 02:47:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 06:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65928-submit@debbugs.gnu.org id=B65928.169476041521813 (code B ref 65928); Fri, 15 Sep 2023 06:47:02 +0000 Original-Received: (at 65928) by debbugs.gnu.org; 15 Sep 2023 06:46:55 +0000 Original-Received: from localhost ([127.0.0.1]:41875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh2bO-0005fk-P0 for submit@debbugs.gnu.org; Fri, 15 Sep 2023 02:46:54 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:50437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh2bK-0005fS-Aj for 65928@debbugs.gnu.org; Fri, 15 Sep 2023 02:46:53 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 7FE0F1C0003; Fri, 15 Sep 2023 06:46:36 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Thu, 14 Sep 2023 07:07:30 -0700") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270492 Archived-At: >> It could be bound to 'C-x p C-x s'. After more thoughts, it's not the best keybinding: the global 'C-x s' could be used to save all buffers in another project with 'C-x p p ... C-x s' implemented in bug#63648. > What's the binding in projectile? All else being equal, I'd suggest we > use the same one. Maybe Projectile's binding 'C-x p S' is not too bad. > Would something like > (defalias 'project-save-buffers #'save-some-buffers-root) > do the job? Rather something more like this will do the job: ``` (keymap-set project-prefix-map "S" (lambda (&optional arg) (interactive "P") (let ((save-some-buffers-default-predicate 'save-some-buffers-root)) (save-some-buffers arg)))) ```