From: Eli Zaretskii <eliz@gnu.org>
To: Daniel Pettersson <daniel@dpettersson.net>
Cc: 69733@debbugs.gnu.org
Subject: bug#69733: [PATCH] Flyspell (flyspell-word): do not force 'save-excursion' on timers
Date: Tue, 12 Mar 2024 15:20:10 +0200 [thread overview]
Message-ID: <86ttlbtwmt.fsf@gnu.org> (raw)
In-Reply-To: <m2sf0wzvek.fsf@dpettersson.net> (message from Daniel Pettersson on Mon, 11 Mar 2024 15:37:55 +0100)
> From: Daniel Pettersson <daniel@dpettersson.net>
> Date: Mon, 11 Mar 2024 15:37:55 +0100
>
> As I understand the manual there is nothing that states that one should
> assume that you cant move the point in buffer with timers. This is of
> course impossible to guarantee as any code can be calling
> accept-process-output. But it seams like an good idea to have code that
> is triggered by post-command-hook to not impose such conditions.
Thanks, but I don't think I understand the relation between what you
say above (and in the comments in your patch below) and the code
change you propose:
> (while (progn
> - (accept-process-output ispell-process)
> + ;; don't force save-excursion to timers.
> + ;; only accept output from ispell-process.
> + (accept-process-output ispell-process nil nil t)
Where's save-excursion and point moving to which you allude here?
More importantly, why is it a good idea to stop running timers during
this accept-process-output call and ignore output from other
subprocesses?
next prev parent reply other threads:[~2024-03-12 13:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 14:37 bug#69733: [PATCH] Flyspell (flyspell-word): do not force 'save-excursion' on timers Daniel Pettersson
2024-03-12 13:20 ` Eli Zaretskii [this message]
2024-03-12 14:28 ` Daniel Pettersson
2024-03-14 10:36 ` Eli Zaretskii
2024-03-15 11:29 ` Daniel Pettersson
2024-03-15 12:36 ` Eli Zaretskii
2024-03-15 15:59 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ttlbtwmt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69733@debbugs.gnu.org \
--cc=daniel@dpettersson.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).