From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Thu, 18 Apr 2024 19:21:39 +0300 Message-ID: <86ttjyd4ks.fsf@gnu.org> References: <43de4151-ab68-4214-8691-33f3554feba1@email.android.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39310"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70036@debbugs.gnu.org, felician.nemeth@gmail.com, joaotavora@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 18 18:23:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxUXc-0009wa-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Apr 2024 18:23:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxUXE-0007xF-LA; Thu, 18 Apr 2024 12:22:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxUXD-0007x7-80 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:22:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxUXC-0000Yl-Vp for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:22:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxUXQ-0005vq-FP for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:23:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2024 16:23:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171345732522376 (code B ref 70036); Thu, 18 Apr 2024 16:23:04 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 18 Apr 2024 16:22:05 +0000 Original-Received: from localhost ([127.0.0.1]:53307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxUWS-0005oq-IO for submit@debbugs.gnu.org; Thu, 18 Apr 2024 12:22:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxUWP-0005nh-D3 for 70036@debbugs.gnu.org; Thu, 18 Apr 2024 12:22:02 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxUW6-0000Nr-2c; Thu, 18 Apr 2024 12:21:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=kASUMv4ukYP0onJxhImYdKwW4hZXi4/PfidvmZuJcK0=; b=aEhUfRvF9FHvKeHStX7i e13TE5UiqDIGl0heg+gfVHzcgPVIyhqUh567OpfPLFJ/nEmM1Ox1slrFU8ZXZXjlfhoWe6Yq85RhL +NDbtXjL+9KOVbZFJIPxJHw0Cj2te9YSgyZVgHlzxB8H7JDhrJVyf+v/Ygj+lTGIR9UPmk/7YkL37 FhagGdHd3IR/QsLogeSFBdV0vkAdWKFydQfhYdPIxaxZCwsNCUHZEidnVAb/zDMdzLw0bCmgbzHo4 7mGFGIieDsi0KDGCo/J4MK0SnYxyDdYE7TWKEd2VszXROo5bOsqo00qzVL4qWdpjPFBE/p4VhXrUs 2rEIE0NN8TMtXQ==; In-Reply-To: <43de4151-ab68-4214-8691-33f3554feba1@email.android.com> (message from Theodor Thornhill on Thu, 18 Apr 2024 18:11:36 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283585 Archived-At: > Date: Thu, 18 Apr 2024 18:11:36 +0200 > From: Theodor Thornhill > Cc: João Távora , > felician.nemeth@gmail.com, 70036@debbugs.gnu.org > > >> If so, I think this simpler patch after my sig is all we need, as it > >> completely clears the profile of any "file-truename". I have reverted > >> the earlier patch and pushed a patch very similar to the one after my sig. > > That's unfortunate. > > > > > This new code should also be timed and compared to the other two > > versions, before we make the final decision on this. > > > This is a very unfortunate change. This completely misses the point and > reverts any perf gains from my previous patch... I think your > conclusions are too quick, and actions likewise. > > I'd argue that long paths are a way more common occurrence than > symlinking, and the places you touched in your "better way" ignores the > performance critical parts. Please show timing data which compares the possible variants. We must have quantitative data to have a firm basis for this discussion. I don't yet have an opinion what we should do about this issue, and I cannot form an opinion unless I see some real-life measurements. I asked João to present such measurements as well.