From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: Eli Zaretskii <eliz@gnu.org>, 71466@debbugs.gnu.org, me@eshelyaron.com
Subject: bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted
Date: Thu, 20 Jun 2024 19:38:58 +0300 [thread overview]
Message-ID: <86tthnzp19.fsf@mail.linkov.net> (raw)
In-Reply-To: <e9820fe1-0906-41a5-98e9-1ecba21adf3d@gutov.dev> (Dmitry Gutov's message of "Tue, 18 Jun 2024 20:47:52 +0300")
>>> And it makes sense to provide this feature to the users of
>>> xref-revert-buffer, so I don't see why not.
>> All things being equal, leaving the old names of the functions and
>> commands should be preferred. That's all I'm saying. It's a minor
>> issue, but the cost of staying more compatible is also minor.
>
> It might be important for the case when somebody has rebound 'g' in Xref
> buffers to some other letter - then they reference xref-revert-buffer by
> name in their init script.
>
> Having them end up with a subpar version of it (and perhaps not notice it
> either) feels like an unfortunate outcome.
So what is the decision? Maybe better to keep xref-revert-buffer
as a wrapper around the new function xref--revert-buffer?
(defun xref-revert-buffer ()
(let (restore-functions)
(when (boundp 'revert-buffer-restore-functions)
(run-hook-wrapped 'revert-buffer-restore-functions
(lambda (f) (push (funcall f) restore-functions) nil)))
(prog1 (xref--revert-buffer)
(mapc #'funcall (delq nil restore-functions)))))
next prev parent reply other threads:[~2024-06-20 16:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 8:49 bug#71466: 30.0.50; Buffer-menu-group-by non-nil resets point when Buffer List is reverted Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-11 17:05 ` Juri Linkov
2024-06-17 6:35 ` Juri Linkov
2024-06-17 7:40 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 12:27 ` Dmitry Gutov
2024-06-17 15:43 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 22:24 ` Dmitry Gutov
2024-06-18 7:00 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-18 12:58 ` Eli Zaretskii
2024-06-18 14:01 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-18 14:46 ` Eli Zaretskii
2024-06-18 16:55 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-18 17:05 ` Dmitry Gutov
2024-06-18 17:36 ` Eli Zaretskii
2024-06-18 17:47 ` Dmitry Gutov
2024-06-20 16:38 ` Juri Linkov [this message]
2024-06-20 17:35 ` Dmitry Gutov
2024-06-24 6:27 ` Juri Linkov
2024-06-24 22:42 ` Dmitry Gutov
2024-06-25 6:54 ` Juri Linkov
2024-06-25 12:54 ` Eli Zaretskii
2024-06-25 23:14 ` Dmitry Gutov
2024-06-26 11:25 ` Eli Zaretskii
2024-06-26 16:56 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-26 18:33 ` Eli Zaretskii
2024-06-26 21:05 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-27 6:39 ` Juri Linkov
2024-06-27 7:19 ` Eli Zaretskii
2024-06-27 0:11 ` Dmitry Gutov
2024-06-17 12:32 ` Dmitry Gutov
2024-06-17 16:31 ` Juri Linkov
2024-06-17 22:16 ` Dmitry Gutov
2024-06-27 6:43 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tthnzp19.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=71466@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).