From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71935: split-string-and-unquote mishandles dired-listing-switches with ' Date: Thu, 04 Jul 2024 21:54:02 +0300 Organization: LINKOV.NET Message-ID: <86tth52dkl.fsf@mail.linkov.net> References: <86tth5tztt.fsf@mail.linkov.net> <86zfqx8tnn.fsf@gnu.org> <86a5ixqhd4.fsf@mail.linkov.net> <868qyh82is.fsf@gnu.org> <8634opowlq.fsf@mail.linkov.net> <8634op80r5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10236"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: 71935@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 20:58:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPRf1-0002Xn-R0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 20:58:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPRec-0001L7-6G; Thu, 04 Jul 2024 14:58:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPRea-0001Kl-3C for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:58:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPReZ-00047D-Rf for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:57:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPRec-0002GZ-6J for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 14:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 18:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71935 X-GNU-PR-Package: emacs Original-Received: via spool by 71935-submit@debbugs.gnu.org id=B71935.17201194508671 (code B ref 71935); Thu, 04 Jul 2024 18:58:02 +0000 Original-Received: (at 71935) by debbugs.gnu.org; 4 Jul 2024 18:57:30 +0000 Original-Received: from localhost ([127.0.0.1]:42989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRe6-0002Fn-B4 for submit@debbugs.gnu.org; Thu, 04 Jul 2024 14:57:30 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:48783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPRe4-0002Fa-Qv for 71935@debbugs.gnu.org; Thu, 04 Jul 2024 14:57:29 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id F3916FF802; Thu, 4 Jul 2024 18:57:19 +0000 (UTC) In-Reply-To: <8634op80r5.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jul 2024 21:34:22 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288393 Archived-At: >>> 1. (setopt dired-listing-switches "-al --block-size='1") >>> 2. C-x d /tmp/* > > If they are a single string, split it with split-string-and-unquote, > then concatenate after running each one through shell-quote-argument. > If they are a list of strings, quote each one before concatenating > with mapconcat. Ok, this seems to work: diff --git a/lisp/files.el b/lisp/files.el index 042b8e2d515..6ed07f02890 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -8195,9 +8193,11 @@ insert-directory "\\") ; Disregard Unix shell aliases! insert-directory-program " -d " - (if (stringp switches) - switches - (mapconcat #'identity switches " ")) + (mapconcat #'shell-quote-argument + (if (stringp switches) + (split-string-and-unquote switches) + switches) + " ") " -- " ;; Quote some characters that have ;; special meanings in shells; but