From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command Date: Tue, 23 Jul 2024 09:37:54 +0300 Organization: LINKOV.NET Message-ID: <86ttggr4u5.fsf@mail.linkov.net> References: <87r0bsn0ok.fsf@gmail.com> <86le1xkh8w.fsf@mail.linkov.net> <87r0bpu6tn.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31345"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: 72147@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 23 08:40:37 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sW9CO-00082p-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jul 2024 08:40:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sW9C5-0003io-FY; Tue, 23 Jul 2024 02:40:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sW9Bn-00038l-RA for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 02:40:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sW9Bl-00057M-Ug for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 02:39:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sW9Bp-0007Zx-V8 for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 02:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2024 06:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72147 X-GNU-PR-Package: emacs Original-Received: via spool by 72147-submit@debbugs.gnu.org id=B72147.172171679229103 (code B ref 72147); Tue, 23 Jul 2024 06:40:01 +0000 Original-Received: (at 72147) by debbugs.gnu.org; 23 Jul 2024 06:39:52 +0000 Original-Received: from localhost ([127.0.0.1]:59021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sW9Bg-0007ZK-6J for submit@debbugs.gnu.org; Tue, 23 Jul 2024 02:39:52 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:59209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sW9Bd-0007Yq-Q7; Tue, 23 Jul 2024 02:39:50 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 03E17FF806; Tue, 23 Jul 2024 06:39:37 +0000 (UTC) In-Reply-To: <87r0bpu6tn.fsf@gmail.com> (Visuwesh's message of "Fri, 19 Jul 2024 13:55:24 +0530") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289142 Archived-At: close 72147 31.0.50 thanks >> Shouldn't query-replace-lazy-highlight be added to all >> functions in dired that use query-replace-read-args? > > Yes, you're right. I have attached a patch that does it. Thanks for the patch, now pushed to master. > BTW, is there a reason why xref--query-replace-1 let-binds > query-replace-lazy-highlight to nil? I guess for the same reason why you let-bind it to nil in Dired, i.e. in Xref it's called in an irrelevant buffer too.