From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72425: 29.2.50; substring (and other PCM styles) fails with candidates containing newlines Date: Thu, 15 Aug 2024 10:43:25 +0300 Message-ID: <86ttfm6xk2.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26448"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 72425-done@debbugs.gnu.org, dmitry@gutov.dev To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 15 09:44:46 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1seVA5-0006jt-UG for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Aug 2024 09:44:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1seV9r-0006Zo-24; Thu, 15 Aug 2024 03:44:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seV9m-0006Yv-KL for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2024 03:44:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1seV9m-0006E8-Ba for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2024 03:44:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=S3UCji0ekU2vMaL+CzcyidkEae9wXm59alEeHuUUreg=; b=npWWlzC9WrPip6dJMGjAHCS2v4BqoUQWAQWQgJfB9MzBjYtyzWYgw1KbLI9/1u0MW/pKyPNSoJjaHznqT62TbfL8KA8t3VbQHW2dJj4810Byi/F5E9UdO62uoX60DRTuQ8V8ljn1Yd9MFglHGd7LRL3wSsjfMprrLn9RGCDy3cRSzNeYbZX3auuHRbycTlZ2CvyVV9r4n8nxA+562IhEs30S5TGwAgBWI47LIjlrD/k3igG6BzbKH+GZ3UcW3gUPGhuXI1hVdjr4ilyBQ6MnlCmXNQl7Ofqs6tLoIVJDXfI0Uqmbp6KohCIV/97/hadTmn4uk7vZnmJALYw7H8bfQw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1seVAM-0004T2-5L for bug-gnu-emacs@gnu.org; Thu, 15 Aug 2024 03:45:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Aug 2024 07:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 72425 X-GNU-PR-Package: emacs Mail-Followup-To: 72425@debbugs.gnu.org, eliz@gnu.org, sbaugh@janestreet.com Original-Received: via spool by 72425-done@debbugs.gnu.org id=D72425.172370785317101 (code D ref 72425); Thu, 15 Aug 2024 07:45:01 +0000 Original-Received: (at 72425-done) by debbugs.gnu.org; 15 Aug 2024 07:44:13 +0000 Original-Received: from localhost ([127.0.0.1]:48275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seV9Y-0004Rj-Mj for submit@debbugs.gnu.org; Thu, 15 Aug 2024 03:44:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seV9W-0004RU-2f for 72425-done@debbugs.gnu.org; Thu, 15 Aug 2024 03:44:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seV8q-0006AD-8e; Thu, 15 Aug 2024 03:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=S3UCji0ekU2vMaL+CzcyidkEae9wXm59alEeHuUUreg=; b=SgfpkUeEOyuSAx5uuzzf OIehCzzpNTc+znDgALoExjHXEDwGBKMEG75BdEbQbeo8iwpjlZGs+U//f1Nxe3dRQ0yt9XubAummo 6eUsgbZS/wUjt4DfS/aCrLsSNYHWLszBoCj6Hbhs0N41HFP0BVszdq4fWAibqTlH2d+oon3JVkK6u R9/k5kT1qWIPG+GLn5E/eoFtHZZXnIK10JPigj+nXotr3M6PNZMz2P42h19UeGCnhMbgOS/N7zL+D K7RetVp+6+b9/34s6dRT5z++KNmZRuuJtXkz1iXz1XdYAJ9dgeeW53G1hgR6tS4wfFVlTHZNzla46 WMgJ/pcMS8SKCg==; In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290167 Archived-At: > Cc: 72425@debbugs.gnu.org, Dmitry Gutov > Date: Tue, 13 Aug 2024 20:51:28 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Patch to fix: > > > > From dfac112fa23d503b671fa5f9901411a4556bf054 Mon Sep 17 00:00:00 2001 > > From: Spencer Baugh > > Date: Fri, 2 Aug 2024 12:15:58 -0400 > > Subject: [PATCH] Fix partial-completion for completion candidates containing > > newlines > > > > partial-completion tries to match a pattern containing wildcards (such > > as `any' or `prefix') against completion candidates. Wildcards are > > supposed to match any sequence of characters, but > > completion-pcm--pattern->regex transformed the wildcards into ".*", > > which won't match sequences containing newlines. Fix this to properly > > match anything by using "[^z-a]*" instead. (That's (rx (* anything))) > > Looks fine to me. I find [^z-a] a bit too magical, so maybe an `rx` > pattern would be more clear. Thanks, installed on master, and closing the bug. > My guess is that completion of thingies with newlines is probably going > to bump into other problems. 🙂 Exciting new bugs!