unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dmitry@gutov.dev, daanturo@gmail.com, 72573@debbugs.gnu.org
Subject: bug#72573: 29.4; js-mode/JSX: forward-sexp behavior at end of string in JSX fragments
Date: Sun, 01 Sep 2024 20:02:29 +0300	[thread overview]
Message-ID: <86ttezmhne.fsf@mail.linkov.net> (raw)
In-Reply-To: <86ikvqnwxm.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Aug 2024 11:32:05 +0300")

>> @@ -3929,7 +3929,8 @@ js-ts-mode
>>                     (sexp ,(js--regexp-opt-symbol js--treesit-sexp-nodes))
>>                     (sentence ,(js--regexp-opt-symbol js--treesit-sentence-nodes))
>>                     (text ,(js--regexp-opt-symbol '("comment"
>> -                                                   "template_string"))))))
>> +                                                   "template_string"
>> +                                                   "string_fragment"))))))
>> 
>> But since this bug report about the default non-ts behavior,
>> I have no idea why the default forward-sexp-function moves to
>> the beginning of the next string.  Maybe this was implemented
>> because the default ad-hoc syntax parsing is not reliable and might
>> mix up string beginnings and endings.  tree-sitter has no such problem.
>
> So what is our way forward with this?  Should we install the above
> patch, or should we close this bug ans wontfix?

I pushed the above patch with small changes to master.

Since the report was about non-ts modes, and it's not easy to change
the default behavior, probably this can be closed as wontfix.





  parent reply	other threads:[~2024-09-01 17:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-11  9:33 bug#72573: 29.4; js-mode/JSX: forward-sexp behavior at end of string in JSX fragments Daan Ro
2024-08-15  7:54 ` Eli Zaretskii
2024-08-18 13:37   ` Dmitry Gutov
2024-08-18 13:42     ` Eli Zaretskii
2024-08-18 14:11       ` Dmitry Gutov
2024-08-18 14:16         ` Eli Zaretskii
2024-08-18 20:19           ` Dmitry Gutov
2024-08-19  6:42             ` Juri Linkov
2024-08-24  8:32               ` Eli Zaretskii
2024-08-24  9:34                 ` Daan Ro
2024-08-31  9:26                   ` Eli Zaretskii
2024-09-01 17:02                 ` Juri Linkov [this message]
2024-09-14  7:39                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ttezmhne.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=72573@debbugs.gnu.org \
    --cc=daanturo@gmail.com \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).