From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73452: Code lens support in eglot Date: Fri, 27 Sep 2024 09:53:29 +0300 Message-ID: <86tte18u52.fsf@gnu.org> References: <05f4d679-d2cd-409c-aafd-bfac2eda7a21@fbengineering.ch> <86v7ylcatg.fsf@gnu.org> <86ikukc6lz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17900"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73452@debbugs.gnu.org, federico.beffa@fbengineering.ch, joaotavora@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 27 08:54:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1su4sO-0004Sr-KX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Sep 2024 08:54:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1su4s7-0006ju-W0; Fri, 27 Sep 2024 02:54:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su4s6-0006ja-E2 for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2024 02:54:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1su4s6-0008GZ-3B for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2024 02:54:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=YGRLYNTmN8C3o3Bs0v5SBjoriXE3J1u/ZLKggdeB7Bs=; b=slQN8/4zqFv63WcbS7nMX+lLVSAyRMbPWCEbVcohwIz+auDDUtkp8g5Ta7WBwczxOovd7Mbov1fCoEMneXc59U9SFyoc84JwducucwGrJadTKsoIbbDEPoG1NbnKISxQ586clAwCz7zD7Gs8HeALUrfJbnYSjdZhDBpOclxTP4aP37VCM1Ahp4mnF9+lzSZfzEyTKAhV68izWCtKlF7/jxMC6+zSyxF3Z000zrW2FFHNxtNKVTc7pVPZG01yGUldxohYpG+vTJa9TA+YU7kKMdaydX+DYPsu9vzQ8pkIOZ5uXxVb0Ctl/Ek6n8V2cBOi0HJqz3PrdMJa0IWaJgwRPg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1su4sY-00024r-7u for bug-gnu-emacs@gnu.org; Fri, 27 Sep 2024 02:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Sep 2024 06:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73452 X-GNU-PR-Package: emacs Original-Received: via spool by 73452-submit@debbugs.gnu.org id=B73452.17274200507884 (code B ref 73452); Fri, 27 Sep 2024 06:55:02 +0000 Original-Received: (at 73452) by debbugs.gnu.org; 27 Sep 2024 06:54:10 +0000 Original-Received: from localhost ([127.0.0.1]:45329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su4ri-000235-43 for submit@debbugs.gnu.org; Fri, 27 Sep 2024 02:54:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1su4rf-00022o-GG for 73452@debbugs.gnu.org; Fri, 27 Sep 2024 02:54:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1su4r7-0008BK-4Y; Fri, 27 Sep 2024 02:53:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YGRLYNTmN8C3o3Bs0v5SBjoriXE3J1u/ZLKggdeB7Bs=; b=c6SDGC3b90/4 zEPv54JmTZa3FzxEfOvBhcpLBKoTWMbEKvhKDq1QzaxuINQKstXPGlIbT0HarQUSu9XHZz8M6IH63 lPyVvIS1c2GRZPx/ga6IG2WLz8B4qW5Dz7WXjcWc3bVyUiHK006RNGH3he9gKK3Z0r2lPxR37rFNC vX13zQq1iBnrvNEH2Vwed5+yQYErQkZNxjcTYpvg42RxGEIfZtM5ETLYjWJjSPaUY8JSIZm0f39wo bhzzaFNv23CvSLUUDELc7c1Ufba/PSVZQU8opIL6YPGE1zs09UU8q2REb/+BB+VbKUDFIZQ1E8ur6 jEqlQe81PEJ3EK/7SnqJqQ==; In-Reply-To: (message from Dmitry Gutov on Fri, 27 Sep 2024 03:20:35 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292494 Archived-At: > Date: Fri, 27 Sep 2024 03:20:35 +0300 > Cc: 73452@debbugs.gnu.org, federico.beffa@fbengineering.ch > From: Dmitry Gutov > > It seems to me that a brief description would be "buttons that do > things", but unlike Code Actions - already available in Eglot - those > things don't typically alter the text that they act on. This seems to be in contradiction with what's been said previously (and my understanding from reading the linked pages): that code lenses are UI sugar for server actions. (If this is different from "Code Actions", then I guess there's some subtlety here I don't get yet.) You yourself say later that "the strongest point of code lenses is advertising actions specific to language and/or to a context", which seems to affirm my understanding. And since Eglot already supports actions, what seems to be missing is that UI sugar, i.e. a way of presenting the lenses and a way for the user to select those he/she wants to invoke.