From: Eli Zaretskii <eliz@gnu.org>
To: Felician Nemeth <nemethf@tmit.bme.hu>
Cc: daniel@dpettersson.net, 72941@debbugs.gnu.org, joaotavora@gmail.com
Subject: bug#72941: jsonrpc: Check if parameters are in line with the spec
Date: Sat, 28 Sep 2024 11:47:13 +0300 [thread overview]
Message-ID: <86tte06u7i.fsf@gnu.org> (raw)
In-Reply-To: <87ikuzzdcj.fsf@betli.tmit.bme.hu> (message from Felician Nemeth on Fri, 13 Sep 2024 19:13:16 +0200)
So do we want to close this as wontfix?
> From: Felician Nemeth <nemethf@tmit.bme.hu>
> Cc: Eli Zaretskii <eliz@gnu.org>,
> João Távora
> <joaotavora@gmail.com>,
> 72941@debbugs.gnu.org
> Date: Fri, 13 Sep 2024 19:13:16 +0200
>
> >>> Would it be possible to extend jsonrpc.el to check the params argument
> >>> of jsonrpc-request, jsonrpc-notify, and jsonrpc-async-request whether it
> >>> is a structured value? And if it is not, then guide the programmer to
> >>> the above URL with a warning.
> >
> > The use case makes sense to me, but I would go with updating the docs
> > rather then the API. The current wording could use some love as it's
> > refereed to as JSON object or plist (at different functions). When it
> > should be plist or vector, where we could throw in a link to the
> > specification.
>
> Makes sense.
>
> > I am not for signaling an error or similar as it's a breaking change in
> > my book, which does not seam called for in this case.
>
> Maybe when the server responds with an error to a jsonrpc-request, then
> jsonrpc.el could create an additional warning if the params of the
> request was not structured. Or maybe it is too much work for a very
> small gain.
>
> Thank you.
>
next prev parent reply other threads:[~2024-09-28 8:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 16:26 bug#72941: jsonrpc: Check if parameters are in line with the spec Felician Nemeth
2024-09-02 11:26 ` Eli Zaretskii
2024-09-05 20:35 ` Daniel Pettersson
2024-09-13 17:13 ` Felician Nemeth
2024-09-28 8:47 ` Eli Zaretskii [this message]
2024-09-28 11:40 ` Daniel Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tte06u7i.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72941@debbugs.gnu.org \
--cc=daniel@dpettersson.net \
--cc=joaotavora@gmail.com \
--cc=nemethf@tmit.bme.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).