From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sat, 09 Nov 2024 11:37:51 +0200 Message-ID: <86ttcgn3ww.fsf@gnu.org> References: <87y12lo9hb.fsf@gmail.com> <86a5epakma.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4447"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73862@debbugs.gnu.org To: trevor.m.murphy@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 09 10:39:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9hwH-000108-2W for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Nov 2024 10:39:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9hvt-0007Pu-3K; Sat, 09 Nov 2024 04:39:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9hvq-0007Pa-Tk for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 04:39:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9hvq-0003sa-Lc for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 04:39:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=UndJLmBgROauaPd4gSNEtXaImcRcHwGSxBkpRj8no7E=; b=i2VEddAG6NNcwOE9t1O48nQB3F6Ea1yCNoGLHz9hnc2f3KuQuKloSbF6AWvZ4zG8dUYzbAzyjU6fAHAcXUI1nvs2p2GtY7+PE0Sx6trXRk38DcIAT+j5tazstFgjBISX+e6ZgyIaWA0thotMIxOIPYINPPO3ErGCPUjBiL/WO/tOReAJL8wIpG6uN+/AvthQdsxKl26ekqYj2Ayft3vv0LsTqmuchaeWqWxVu6udfkMrumJ2CqHJNjWkCCjiwLiZfkCrspzRfCPv9nvJOc0QOC+94JdgiVY8qWal7LuUMQXSwpn5qj4WM5d8Vf/P6j6I8kg0jv6TsWqJ2lm/ooz0qA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9hvq-0002Uz-A1 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 04:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2024 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.17311450839529 (code B ref 73862); Sat, 09 Nov 2024 09:39:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 9 Nov 2024 09:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:53448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9hut-0002Td-GI for submit@debbugs.gnu.org; Sat, 09 Nov 2024 04:38:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9huq-0002T2-F3 for 73862@debbugs.gnu.org; Sat, 09 Nov 2024 04:38:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9hul-0003rU-4l; Sat, 09 Nov 2024 04:37:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UndJLmBgROauaPd4gSNEtXaImcRcHwGSxBkpRj8no7E=; b=Ra1Z41pDjdO9 xzFl4e3arDGsLF6GgMiHt3Ci/1nH0iMBIsXegqw7T1AFr3bzlIN9SJo9SFNFHFZgienxx6QHYejcY KtVrv6gAbr5CAs0HgcBeA+Ex+g9betP1Qeh5l0ay1qlFQKia4KSOOIok+teBmYK1LASjYjWHyyIjN L3CjcvDmfjrzmaO2+esjS0zKRVZgM1BeugH2QgiGll2jPJP7K7NT6+JuBIPVBynQK9NImBBTw9HZA 1Cq71E3egsTYVar8OuVz+VzwK3EGkuvzZmT4z8K6EvktJGzPP3RbGcoj76xm9AcrXQSPKXQUrsfH+ G3LAbJe767HKbDpGtf46hg==; In-Reply-To: <86a5epakma.fsf@gnu.org> (message from Eli Zaretskii on Sun, 27 Oct 2024 12:46:53 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295114 Archived-At: > Cc: 73862@debbugs.gnu.org > Date: Sun, 27 Oct 2024 12:46:53 +0200 > From: Eli Zaretskii > > > From: trevor.m.murphy@gmail.com > > Date: Fri, 18 Oct 2024 05:56:32 -0700 > > > > Over the years I've put more and more information into the header line, and at some point I wanted to get that quick visual indicator of selected vs non-selected windows when I glanced at the header as I already got from the mode line. > > > > This was surprisingly hard to achieve! For a few years I used an ugly `buffer-list-update-hook` hack. Then a few months ago I got adventurous and found that it actually wasn't as hard as I'd feared to hack these into the C source. > > > > The new faces both inherit from the current `header-line` face, so there shouldn't be any visible impact if users don't customize the new faces. For cases like mine it's easy to customize header-line-inactive to inherit from mode-line-inactive. > > > > Thanks in advance for your attention and feedback, > > Thanks. This changeset needs the appropriate changes in the Emacs > user manual (which lists the standard faces in "Standard Faces"), and > also a NEWS entry that announces the change. > > Also, did you verify that modes which use header-line and customize > the header-line face still work as before after this change, both when > the window is selected and non-selected? Ping! Trevor, could you please answer the above question, and provide an updated patch with documentation changes? I'd like to install this as soon as these issues are resolved.