unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>
Cc: 74775@debbugs.gnu.org
Subject: bug#74775: [PATCH] Update browse-url-kde variables
Date: Wed, 11 Dec 2024 18:14:25 +0200	[thread overview]
Message-ID: <86ttba2o4e.fsf@gnu.org> (raw)
In-Reply-To: <87cyhyuxjh.fsf@thaodan.de> (message from Björn Bidar on Wed, 11 Dec 2024 16:03:30 +0200)

> From: Björn Bidar <bjorn.bidar@thaodan.de>
> Cc: 74775@debbugs.gnu.org
> Date: Wed, 11 Dec 2024 16:03:30 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >>    :type 'string
> >
> > Should this be 'file instead?
> 
> Does 'file for programs in path?

No, but the user could enter an absolute file name here, in which case
'file will be more useful.

> >> -(defcustom browse-url-kde-args '("openURL")
> >> +(defcustom browse-url-kde-args nil
> >>    "A list of strings defining options for `browse-url-kde-program'."
> >
> > Should the default value depend on the value of
> > browse-url-kde-program?  E.g., if that is customized to kfmclient, the
> > value of this variable should probably not be '("openURL"), right?
> 
> For kfmclient it should be '("openURL") for others not.
> 
> I think it would make sense to apply this change to Emacs 30 too as it
> isn't a functionality change but a fix to not use kfmclient which is not
> installed anymore these days as the default file manager for KDE is
> Dolphin and not Konqueror which includes kfmclient.

I'd prefer not to change defaults in Emacs 30 at this point, but if
you think the current defaults might be not useful, then I'll ask in
what version(s) of current systems using KDE this change happened, and
how probable is it that users are still using those old versions?

Installing on master doesn't need to delve into these issues, since if
we are wrong, we have enough time for users to holler and for us to
fix.  Emacs 30, OTOH, is very close to the release, so we must be very
certain this change cannot cause any trouble.





  parent reply	other threads:[~2024-12-11 16:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8734ivrvfr.fsf@>
2024-12-11 12:38 ` bug#74775: [PATCH] Update browse-url-kde variables Eli Zaretskii
2024-12-11 14:03   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 14:28     ` Robert Pluim
2024-12-11 16:14     ` Eli Zaretskii [this message]
2024-12-11 17:41       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-11 19:07         ` Eli Zaretskii
     [not found] <6758c999.050a0220.38af58.bd51SMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-11  1:22 ` Stefan Kangas
2024-12-10 23:04 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ttba2o4e.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74775@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).