From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75291: Redisplay not updating fringe when face filter changes Date: Fri, 03 Jan 2025 22:27:45 +0200 Message-ID: <86ttaffxry.fsf@gnu.org> References: <874j2h3yzb.fsf@dancol.org> <8634i1jeai.fsf@gnu.org> <87ttah2hcd.fsf@dancol.org> <86v7uxhv9c.fsf@gnu.org> <87ikqx2dwh.fsf@dancol.org> <86h66hhr3a.fsf@gnu.org> <87ldvrajym.fsf@dancol.org> <867c7bheyp.fsf@gnu.org> <87sepz65pv.fsf@dancol.org> <86wmfbfyka.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32070"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75291@debbugs.gnu.org, mina86@mina86.com To: dancol@dancol.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 03 21:28:19 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tToHK-0008Db-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Jan 2025 21:28:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tToH6-0000fn-QV; Fri, 03 Jan 2025 15:28:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tToH5-0000fO-0L for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 15:28:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tToH4-0000fI-OC for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 15:28:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=6bmIcaF7ReTVW4sEVDlYtyC/gGgaELHmmP0pNX5ODiY=; b=H/Q287SS4fRv1jjuJI0NxNJCcmZfPZdnVEatkI5i4L9/stA6ASSNEYFFRGQrLzl6MYwfTWYCIeLST7I7hv5Wod2oE4/ObxVp3x4f1PXrmkCbmQJdJDm9rNRxYwIa1sE9yFLTQRBSJa/d8fmSKr+92wT2Ry0FYiSLZ1362OBPjef07pkpOHrGGXjqpNeh3XElhl18U7+LXSkDs5Pen0/z7OVQiuKHpjQccP8GfO+F1EX4xvhEQvKoWdCwdqw/WEENU0mR4mG3l4IUHszYAGSfSvwVrzJpHYA3YXsVEErWJo2W9bd8fthjG8LETltPsxTYDKeELAX7oGGzDl8hbIgdbA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tToH3-0007dY-OH for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2025 15:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2025 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75291 X-GNU-PR-Package: emacs Original-Received: via spool by 75291-submit@debbugs.gnu.org id=B75291.173593607929343 (code B ref 75291); Fri, 03 Jan 2025 20:28:01 +0000 Original-Received: (at 75291) by debbugs.gnu.org; 3 Jan 2025 20:27:59 +0000 Original-Received: from localhost ([127.0.0.1]:52314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tToH1-0007dD-7Z for submit@debbugs.gnu.org; Fri, 03 Jan 2025 15:27:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54846) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tToGx-0007ck-Pv for 75291@debbugs.gnu.org; Fri, 03 Jan 2025 15:27:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tToGq-0000d4-Jd; Fri, 03 Jan 2025 15:27:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6bmIcaF7ReTVW4sEVDlYtyC/gGgaELHmmP0pNX5ODiY=; b=bsqP5iYQgfrl 14Kj7+8aGYgBB8E6LDu619419MAawm0GvgLyvp5a6kOhB2LKEhRA6ZrSj8eYMn8OolBeJh5jOWgD0 tIWgv1UrMpf+WHeDyiLwrjtooseDu+9IqRh2FKn86SpRRq+16NXHmyxhKv6U0X3U5+CxbwFPh2QLX 8op+OmttTodFb9spfzP3URDhQZcHTKwFUWgwAG6QIuEgzGMdxPQQbX7lAqf70XhAPSsYFYPjXjdFR fQfQClz8sAthNUaQTNnAJkhacd2GIBsqGnrZeqfKzeYNjH49GJDaJCYi6sXGrUN9L7Zyq3IS2wnNy XOm4QG1ekqhRrzBBg1jrNA==; In-Reply-To: <86wmfbfyka.fsf@gnu.org> (message from Eli Zaretskii on Fri, 03 Jan 2025 22:10:45 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298311 Archived-At: > Cc: 75291@debbugs.gnu.org, mina86@mina86.com > Date: Fri, 03 Jan 2025 22:10:45 +0200 > From: Eli Zaretskii > > > From: Daniel Colascione > > Cc: 75291@debbugs.gnu.org, mina86@mina86.com > > Date: Fri, 03 Jan 2025 14:46:20 -0500 > > > > Eli Zaretskii writes: > > > > >> From: Daniel Colascione > > >> Cc: 75291@debbugs.gnu.org, mina86@mina86.com > > >> Date: Fri, 03 Jan 2025 12:25:05 -0500 > > >> > > >> > I think it depends on whether you use double-buffering (some people > > >> > don't or cannot) and whether you have the mouse pointer over an Emacs > > >> > frame. Also, depending on the GUI toolkit, the decorations might > > >> > flicker. > > >> > > >> TTY windows don't have fringes, and the most commonly-used window > > >> systems all do atomic updates nowadays. > > > > > > People still report flickering from time to time, so I don't think > > > this never happens. > > > > > >> > So you want to add to display_line code that sets each glyph_row's > > >> > redraw_fringe_bitmaps_p flag when the fringe face changes? That could > > >> > probably work, provided that we disable redisplay optimizations which > > >> > might avoid calling display_line (you will see that we already disable > > >> > such optimizations when overlay_arrows_changed_p returns non-zero). > > >> > We might actually need to disable more of the optimizations, because > > >> > the overlay-arrow thing doesn't contradict the optimizations that > > >> > scroll the pixels, something that reaction to changes in the fringe > > >> > face cannot tolerate. > > >> > > >> That might work, but I don't think we even need anything that > > >> complicated or low-level. Not many are using :filtered now, and those > > >> that do big redraws anyway. How about this simpler code that gets us > > >> correctness, albeit more conservatively? > > > > > > Doesn't that only support face remapping with :filtered attribute? > > > What about the more general case where the fringe face is remapped in > > > a way that's independent of the windows? > > > > That seems to work already. It's only in the fringe that I see problems > > --- it just doesn't seem worth it to limit the redraw to the fringe. > > Sorry, I don't understand. I _was_ talking about the fringe face. > > But if redraw_frame solves the issue, and doesn't cause unpleasant or > expensive redraws, feel free to install on the master branch. But > please change this: Btw: this is _really_ a sledgehammer solution, and it will affect similar changes in any face, not just the fringe face. I wonder how long will it take for complaints to come in. How about leaving behind a variable exposed to Lisp that could be used to disable this sledgehammer? Then we at least could tell people who don't want this how to disable it.