From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73178: 31.0.50; [PATCH] Improve the widget to customize icon Date: Thu, 09 Jan 2025 16:35:56 +0200 Message-ID: <86tta812cz.fsf@gnu.org> References: <53eb31f5-e95d-48c9-a04a-c951a3a057a7@orange.fr> <8cc723b7-c6c5-450d-9832-9039362d63a5@gmail.com> <86ed1c31o6.fsf@gnu.org> <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12052"; mail-complaints-to="usenet@ciao.gmane.io" Cc: maurooaranda@gmail.com, 73178-done@debbugs.gnu.org To: David Ponce Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 09 15:37:26 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVtf3-0002zA-Eu for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jan 2025 15:37:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVtem-0008Uf-Vw; Thu, 09 Jan 2025 09:37:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVteh-0008UG-JI for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 09:37:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVteh-0006VO-2A for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 09:37:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=nbDdqwGwxWY6oA4vWaUjrSHxqpWfrFAF9G28JidMauU=; b=KQ4YGt3oAtJiii/ifeAV1ViOmsEh9kwY0DnyqTAJgOYUfmB+9zSX3Zr16C0tNJR3ITGDb3/e9xd2CeBaUHzacWt266cTWozRDAi38obF4vO6pWD4jOSNfyllfZ/ZSm1tly6BeFLCSPFU78EQ7/YmXc0s4KSEhIF2nanASJs8GVh8GeRua0g7Cm3nF6fOKHAAloHZ+XuHOuZD1Evu7tRCwUpfHrxrn1hH54WLdxeKN80EQ5F9F5RNjqVNuF0fWzOVYnHCSsU+/MWfO94bzJ7wCgu2SmEbyMh2kkd3QMZXe2P1IuiMJu5x3Ln1DRg/due91dD0BPP76Pd6kg3ntsZEVw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVteg-000340-SB for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 09:37:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 73178 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 73178@debbugs.gnu.org, eliz@gnu.org, da_vid@orange.fr Original-Received: via spool by 73178-done@debbugs.gnu.org id=D73178.173643336811699 (code D ref 73178); Thu, 09 Jan 2025 14:37:02 +0000 Original-Received: (at 73178-done) by debbugs.gnu.org; 9 Jan 2025 14:36:08 +0000 Original-Received: from localhost ([127.0.0.1]:51311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVtdn-00032d-UP for submit@debbugs.gnu.org; Thu, 09 Jan 2025 09:36:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45238) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVtdl-00032I-53 for 73178-done@debbugs.gnu.org; Thu, 09 Jan 2025 09:36:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVtdf-0006Ri-2t; Thu, 09 Jan 2025 09:35:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nbDdqwGwxWY6oA4vWaUjrSHxqpWfrFAF9G28JidMauU=; b=I6tAwPdV5aRm MODXbVyLP/9RYzwH7D7NKufeH3DaT26Coea0NxiZS0kVW9Z2YeJtI5HTf0UQQtYGM2xtJaKSrXKZg 6HeqTV7HK9dfivK2q63mIE1pYv3czbP/rRjquM8fR2jCAWHunpUiDJ5kau0ZD2PbmlBYMltQmjbOh AWZnDmczOtJD/KdaaBdfPTvHzHonTXGsPC/zQV8e2U16SFdJDGzcGYklTZF+EGRWZc2EiF2+Sdtr+ DgRUpWc7nBLTynTd2xeIqrVOT/DSSdAJ72TLjfF2bCaS/+XbOHIt4TohZwZ3B4opYcQDyAQPwG6sL Ek7HjCEsKsJBwAIxszDLew==; In-Reply-To: <822bd2c9-7463-4c55-89c2-2eabd990944d@orange.fr> (message from David Ponce on Thu, 9 Jan 2025 11:01:40 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298838 Archived-At: > Date: Thu, 9 Jan 2025 11:01:40 +0100 > Cc: 73178@debbugs.gnu.org > From: David Ponce > > > I wanted to install this, but byte-compiler produces a warning: > > > > ELC cus-edit.elc > > > > In toplevel form: > > cus-edit.el:5595:20: Warning: reference to free variable `custom-icon--texts-widget' > > > > Is that a typo, and you actually meant custom-icon--texts-sub-type? > > > > Also, could you please accompany the patch with the ChangeLog-style > > commit log message (see CONTRIBUTE for the details)? Otherwise, I > > will have to write the log message manually when installing your > > changes. > > > > Thanks. > > Hello Eli, > > Hmm, it seems you didn't install the correct patch? > I attached the correct patch (V2) which applies cleanly for me. > Also below is my proposed ChangeLog. > > Thank you, and thanks Mauro for your review. Thanks, and sorry for missing the last patch earlier. Now installed on master, and closing the bug.