From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: Stefan Monnier <monnier-CRDzTM1onBSWkKpYnGOUKg@public.gmane.org>
Cc: 14957-ubl+/3LiMTaZdePnXv/OxA@public.gmane.org
Subject: bug#14957: 24.3.50; Flyspell language visible in mode line
Date: Wed, 15 Jan 2014 11:13:42 +0100 [thread overview]
Message-ID: <86sispa6y1.fsf@somewhere.org> (raw)
In-Reply-To: <mailman.11946.1389735261.10748.bug-gnu-emacs-mXXj517/zsQ@public.gmane.org> (Stefan Monnier's message of "Tue, 14 Jan 2014 16:33:05 -0500")
Stefan Monnier wrote:
>> (defconst csv-mode-line-help-echo (get-text-property 0 (quote help-echo)
>> (car default-mode-line-format)) "Primary default mode line help echo text.")
>
> This is clearly a bug in csv-mode.el.
> Try the patch below,
It does work like expected. Thanks!
> diff --git a/packages/csv-mode/csv-mode.el b/packages/csv-mode/csv-mode.el
> index dbc6182..a8ae4e4 100644
> --- a/packages/csv-mode/csv-mode.el
> +++ b/packages/csv-mode/csv-mode.el
> @@ -1,6 +1,6 @@
> ;;; csv-mode.el --- Major mode for editing comma/char separated values -*- lexical-binding: t -*-
>
> -;; Copyright (C) 2003, 2004, 2012, 2013 Free Software Foundation, Inc
> +;; Copyright (C) 2003, 2004, 2012, 2013, 2014 Free Software Foundation, Inc
>
> ;; Author: Francis J. Wright <F.J.Wright at qmul.ac.uk>
> ;; Time-stamp: <23 August 2004>
> @@ -247,10 +247,6 @@ Number of spaces used by `csv-align-fields' after separators."
> ;;; Mode definition, key bindings and menu
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
>
> -(defconst csv-mode-line-help-echo
> - ;; See bindings.el for details of `mode-line-format' construction.
> - (get-text-property 0 'help-echo (car (default-value 'mode-line-format)))
> - "Primary default mode line help echo text.")
>
> (defconst csv-mode-line-format
> ;; See bindings.el for details of `mode-line-format' construction.
> @@ -260,7 +256,6 @@ Number of spaces used by `csv-align-fields' after separators."
> (setcdr x (cons
> `(csv-field-index-string
> ("" csv-field-index-string
> - ;; ,(propertize "--" 'help-echo csv-mode-line-help-echo)
> ))
> (cdr x))))
> ml)
> @@ -803,8 +798,7 @@ Called by `csv-field-index-idle-timer'."
> (when (not (eq field csv-field-index-old))
> (setq csv-field-index-old field
> csv-field-index-string
> - (and field (propertize (format "F%d" field)
> - 'help-echo csv-mode-line-help-echo)))
> + (and field (format "F%d" field)))
> (force-mode-line-update))))))
> \f
> ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Best regards,
Seb
--
Sebastien Vauban
next prev parent reply other threads:[~2014-01-15 10:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 12:59 bug#14957: 24.3.50; Flyspell language visible in mode line Sebastien Vauban
2013-07-26 14:21 ` Stefan Monnier
2013-09-17 16:47 ` Michael Heerdegen
[not found] ` <87wqmfz96x.fsf-S0/GAf8tV78@public.gmane.org>
2013-11-08 20:46 ` Sebastien Vauban
2013-11-08 21:30 ` Michael Heerdegen
2020-09-18 14:19 ` Lars Ingebrigtsen
2020-09-18 15:00 ` Michael Heerdegen
2020-09-18 15:10 ` Lars Ingebrigtsen
2020-09-18 15:45 ` Eli Zaretskii
2020-09-19 14:01 ` Lars Ingebrigtsen
2020-09-19 14:43 ` Eli Zaretskii
2020-09-19 22:31 ` Michael Heerdegen
2020-09-19 22:34 ` Lars Ingebrigtsen
2020-09-18 16:17 ` Michael Heerdegen
[not found] ` <mailman.5609.1383955137.10748.bug-gnu-emacs@gnu.org>
[not found] ` <mailman.5609.1383955137.10748.bug-gnu-emacs-mXXj517/zsQ@public.gmane.org>
2013-11-12 13:29 ` Sebastien Vauban
2013-11-14 0:03 ` Michael Heerdegen
[not found] ` <mailman.6021.1384387520.10748.bug-gnu-emacs@gnu.org>
2013-11-14 10:41 ` Sebastien Vauban
2013-11-14 19:05 ` Stefan Monnier
2014-01-14 8:58 ` Sebastien Vauban
2014-01-14 15:31 ` Michael Heerdegen
2014-01-14 17:04 ` Glenn Morris
[not found] ` <mailman.11900.1389713605.10748.bug-gnu-emacs@gnu.org>
2014-01-14 17:32 ` Sebastien Vauban
2014-01-14 21:33 ` Stefan Monnier
2014-01-15 13:44 ` Michael Heerdegen
2014-01-15 15:23 ` Stefan Monnier
[not found] ` <mailman.11946.1389735261.10748.bug-gnu-emacs@gnu.org>
[not found] ` <mailman.11946.1389735261.10748.bug-gnu-emacs-mXXj517/zsQ@public.gmane.org>
2014-01-15 10:13 ` Sebastien Vauban [this message]
[not found] ` <mailman.11900.1389713605.10748.bug-gnu-emacs-mXXj517/zsQ@public.gmane.org>
2014-01-14 18:12 ` Sebastien Vauban
[not found] ` <mailman.11912.1389719107.10748.bug-gnu-emacs@gnu.org>
[not found] ` <mailman.11912.1389719107.10748.bug-gnu-emacs-mXXj517/zsQ@public.gmane.org>
2014-01-15 10:42 ` Sebastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sispa6y1.fsf@somewhere.org \
--to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
--cc=14957-ubl+/3LiMTaZdePnXv/OxA@public.gmane.org \
--cc=monnier-CRDzTM1onBSWkKpYnGOUKg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).