From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alain Schneble Newsgroups: gmane.emacs.bugs Subject: bug#22789: 25.1.50; In last master build https connections stop working Date: Mon, 7 Mar 2016 17:47:43 +0100 Message-ID: <86si02z13k.fsf@realize.ch> References: <864mcyo14y.fsf@Lenovo-PC.i-did-not-set--mail-host-address--so-tickle-me> <834mctbitq.fsf@gnu.org> <868u25p3m2.fsf@realize.ch> <83io18ahya.fsf@gnu.org> <86y4a3on6f.fsf@realize.ch> <87oaazg7fv.fsf@gnus.org> <86twkro0vr.fsf@realize.ch> <83d1rf8ifj.fsf@gnu.org> <86povfnm9r.fsf@realize.ch> <8337sa9865.fsf@gnu.org> <86bn6ynrbw.fsf@realize.ch> <83vb566v5b.fsf@gnu.org> <83d1razkmq.fsf@gnu.org> <86egbqkwsb.fsf@realize.ch> <86a8mekjrb.fsf@realize.ch> <83k2lhxria.fsf@gnu.org> <86egbo232a.fsf@realize.ch> <83si04wx18.fsf@gnu.org> <8660wz1azm.fsf@realize.ch> <861t7n1970.fsf@realize.ch> <83mvqauv8l.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457369372 7495 80.91.229.3 (7 Mar 2016 16:49:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2016 16:49:32 +0000 (UTC) Cc: larsi@gnus.org, j_l_domenech@yahoo.com, 22789@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 07 17:49:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1acyLL-0001lA-R6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Mar 2016 17:49:15 +0100 Original-Received: from localhost ([::1]:56959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acyLH-00070I-MW for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Mar 2016 11:49:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acyLC-0006zj-3p for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:49:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1acyL8-0007aW-2p for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:49:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acyL7-0007aS-VT for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:49:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1acyL7-0006Co-Pr for bug-gnu-emacs@gnu.org; Mon, 07 Mar 2016 11:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alain Schneble Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Mar 2016 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22789 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22789-submit@debbugs.gnu.org id=B22789.145736932023827 (code B ref 22789); Mon, 07 Mar 2016 16:49:01 +0000 Original-Received: (at 22789) by debbugs.gnu.org; 7 Mar 2016 16:48:40 +0000 Original-Received: from localhost ([127.0.0.1]:38290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acyKi-0006CC-K5 for submit@debbugs.gnu.org; Mon, 07 Mar 2016 11:48:40 -0500 Original-Received: from clientmail.realize.ch ([46.140.89.53]:4814) by debbugs.gnu.org with smtp (Exim 4.84) (envelope-from ) id 1acyKd-0006Bu-R9 for 22789@debbugs.gnu.org; Mon, 07 Mar 2016 11:48:35 -0500 Original-Received: from rintintin.hq.realize.ch.lan.rit ([192.168.0.105]) by clientmail.realize.ch ; Mon, 7 Mar 2016 17:48:10 +0100 Original-Received: from MYNGB (192.168.66.64) by rintintin.hq.realize.ch.lan.rit (192.168.0.105) with Microsoft SMTP Server (TLS) id 15.0.516.32; Mon, 7 Mar 2016 17:47:52 +0100 In-Reply-To: <83mvqauv8l.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar 2016 18:07:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (windows-nt) X-ClientProxiedBy: rintintin.hq.realize.ch.lan.rit (192.168.0.105) To rintintin.hq.realize.ch.lan.rit (192.168.0.105) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:114543 Archived-At: Eli Zaretskii writes: >> From: Alain Schneble >> CC: , , <22789@debbugs.gnu.org> >> Date: Mon, 7 Mar 2016 00:24:35 +0100 >> >> > I'll send a patch for further discussions shortly. >> >> And here it is. The fix is quite simple. It ensures that sys_write >> exits before touching the socket if it is not connected yet. >> Unfortunately I didn't find any documentation on winsock ioctlsocket >> that would prove that this is indeed required. But it seems not wrong >> to me anyway. (I'll try to search the wisock documentation tomorrow to >> find some hints that lead in this direction, or maybe you know?) > > I think this change should be installed regardless, as it fixes an > oversight. However, I think it needs to be augmented, because the > fact that FILE_CONNECT flag is set doesn't necessarily mean the > connection is in progress: it could have failed already. We need to > look at the status as well. Thank you. I'll study the state table later... > So we should only return EWOULDBLOCK when FILE_CONNECT is set _and_ > the status is not STATUS_CONNECT_FAILED. If FILE_CONNECT is set, but > the status is STATUS_CONNECT_FAILED, we should instead return the > value computed from cp->errcode (if it is non-zero). There's an > example of that in sys_read. Ok, thanks for this information. I'll read through that code once again... > Other than that, what specific problem does your change try or is > known to solve? IOW, what didn't work before the change, and works > after it? Aha. Sorry, I was not clear about that. It fixes all the reproducible issues I had when "asynchronously" loading a website with images in eww on MS-Windows (e.g. https://www.microsoft.com). gnutls_handshake returned with arbitrary failures when loading the images. It returned with errors -15 GNUTLS_E_UNEXPECTED_PACKET or -110 GNUTLS_E_PREMATURE_TERMINATION, followed by -10 GNUTLS_E_INVALID_SESSION. It happend all the time, but arbitrarily only for some of the images. The affected images were not downloaded and displayed in eww at all because the GnuTLS session could not be established.