From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47566: 28.0.50; diff-hl should use `repeat-mode' ... and not `smartrep' Date: Mon, 15 Nov 2021 19:40:51 +0200 Organization: LINKOV.NET Message-ID: <86sfvxb9lo.fsf@mail.linkov.net> References: <87pmz8lc17.fsf@mail.linkov.net> <9453a08f-5014-b4bc-8472-a4c2ff44c687@yandex.ru> <87o8eo38q9.fsf@mail.linkov.net> <86h7ceqyt1.fsf@mail.linkov.net> <87k0ha2dlx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35111"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 47566@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 15 18:47:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmg4g-0008zh-W7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 18:47:22 +0100 Original-Received: from localhost ([::1]:49328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmg4f-0004nC-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Nov 2021 12:47:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmg4M-0004n3-V7 for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 12:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmg4M-0007PL-MZ for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 12:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmg4M-0003R1-GK for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2021 12:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Nov 2021 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47566 X-GNU-PR-Package: emacs Original-Received: via spool by 47566-submit@debbugs.gnu.org id=B47566.163699839711995 (code B ref 47566); Mon, 15 Nov 2021 17:47:02 +0000 Original-Received: (at 47566) by debbugs.gnu.org; 15 Nov 2021 17:46:37 +0000 Original-Received: from localhost ([127.0.0.1]:56061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmg3x-00037E-Fp for submit@debbugs.gnu.org; Mon, 15 Nov 2021 12:46:37 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:45611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmg3v-00030O-06 for 47566@debbugs.gnu.org; Mon, 15 Nov 2021 12:46:35 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5AC27E000D; Mon, 15 Nov 2021 17:46:26 +0000 (UTC) In-Reply-To: <87k0ha2dlx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 15 Nov 2021 06:26:50 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220069 Archived-At: >> What would be a general rule when repeating should be disabled? >> Looks like the most relevant event is when the minibuffer pops up >> in the middle of repeating sequence. > > I think that sounds correct. > >> What I'm going to try is a combination of minibuffer-depth and >> current-minibuffer-command. Then in pre-command-hook, >> current-minibuffer-command is 'execute-extended-command', >> but in post-command-hook it's 'hl-test'. > > Sounds promising. So the fix is pushed now.