From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52050: [PATCH] Make tab-line-switch-cycling work with buffer groups Date: Tue, 23 Nov 2021 10:06:09 +0200 Organization: LINKOV.NET Message-ID: <86sfvnpaie.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13564"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52050@debbugs.gnu.org To: Matt Kramer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 23 09:07:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpQph-0003L3-GT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Nov 2021 09:07:17 +0100 Original-Received: from localhost ([::1]:53454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpQpf-0004mL-Oa for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Nov 2021 03:07:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpQpS-0004lv-Ly for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 03:07:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpQpS-000636-D8 for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 03:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpQpS-0003F2-5Z for bug-gnu-emacs@gnu.org; Tue, 23 Nov 2021 03:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Nov 2021 08:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52050 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52050-submit@debbugs.gnu.org id=B52050.163765481012442 (code B ref 52050); Tue, 23 Nov 2021 08:07:02 +0000 Original-Received: (at 52050) by debbugs.gnu.org; 23 Nov 2021 08:06:50 +0000 Original-Received: from localhost ([127.0.0.1]:49877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpQpF-0003Ec-T8 for submit@debbugs.gnu.org; Tue, 23 Nov 2021 03:06:50 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mpQpC-0003EH-OY for 52050@debbugs.gnu.org; Tue, 23 Nov 2021 03:06:48 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 7B5861C000C; Tue, 23 Nov 2021 08:06:38 +0000 (UTC) In-Reply-To: (Matt Kramer's message of "Mon, 22 Nov 2021 20:16:09 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220642 Archived-At: > Currently, `tab-line-switch-cycling' has no effect in the presence of any > tab that isn't associated with a buffer, such as the `group-tab' that > exists when `tab-line-tabs-function' is `tab-line-tabs-buffer-groups'. This > patch modifies `tab-line-switch-to-{next,prev}-tab' to remove any such tab > from consideration. Thanks for the patch. Please send your complete tab-line setup, so we could test and verify that your patch correctly fixes the problem. I see at least these settings: (setq tab-line-switch-cycling t) (setq tab-line-tabs-function 'tab-line-tabs-buffer-groups) But it seems you also modified either tab-line-tabs-buffer-list-function, or tab-line-tabs-buffer-group-sort-function, or both of them. Is this true?