unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Matt Kramer <matt314159@gmail.com>
Cc: 52050@debbugs.gnu.org
Subject: bug#52050: [PATCH] Make tab-line-switch-cycling work with buffer groups
Date: Tue, 23 Nov 2021 10:06:09 +0200	[thread overview]
Message-ID: <86sfvnpaie.fsf@mail.linkov.net> (raw)
In-Reply-To: <CANGn5a5u9dFdPvL90p=mH5yDXLf=bPJTkMkHWhYapwYvSM091A@mail.gmail.com> (Matt Kramer's message of "Mon, 22 Nov 2021 20:16:09 -0800")

> Currently, `tab-line-switch-cycling' has no effect in the presence of any
> tab that isn't associated with a buffer, such as the `group-tab' that
> exists when `tab-line-tabs-function' is `tab-line-tabs-buffer-groups'. This
> patch modifies `tab-line-switch-to-{next,prev}-tab' to remove any such tab
> from consideration.

Thanks for the patch.  Please send your complete tab-line setup,
so we could test and verify that your patch correctly fixes the problem.
I see at least these settings:

  (setq tab-line-switch-cycling t)
  (setq tab-line-tabs-function 'tab-line-tabs-buffer-groups)

But it seems you also modified either tab-line-tabs-buffer-list-function,
or tab-line-tabs-buffer-group-sort-function, or both of them.  Is this true?





  reply	other threads:[~2021-11-23  8:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-23  4:16 bug#52050: [PATCH] Make tab-line-switch-cycling work with buffer groups Matt Kramer
2021-11-23  8:06 ` Juri Linkov [this message]
2021-11-23  9:41   ` Matt Kramer
2021-11-24 19:43     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86sfvnpaie.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=52050@debbugs.gnu.org \
    --cc=matt314159@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).