From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer Date: Sat, 18 Dec 2021 19:20:09 +0200 Organization: LINKOV.NET Message-ID: <86sfupu8xi.fsf@mail.linkov.net> References: <865yrqsxmu.fsf@mail.linkov.net> <865yro7csh.fsf@mail.linkov.net> <83h7b8fngd.fsf@gnu.org> <86v8zo4bma.fsf@mail.linkov.net> <83fsqsfh8i.fsf@gnu.org> <86tuf73aen.fsf@mail.linkov.net> <83h7b7e8t2.fsf@gnu.org> <4318fa2c-0127-4a14-f65e-399b5c097028@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13858"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52491@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 18 18:24:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mydRr-0003QM-1g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 18:24:43 +0100 Original-Received: from localhost ([::1]:57718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mydRq-00009P-5D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Dec 2021 12:24:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mydRC-0007lD-Nd for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 12:24:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60443) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mydRC-0005Mi-Fk for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 12:24:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mydRC-0005Wo-Bv for bug-gnu-emacs@gnu.org; Sat, 18 Dec 2021 12:24:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Dec 2021 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52491 X-GNU-PR-Package: emacs Original-Received: via spool by 52491-submit@debbugs.gnu.org id=B52491.163984821321199 (code B ref 52491); Sat, 18 Dec 2021 17:24:02 +0000 Original-Received: (at 52491) by debbugs.gnu.org; 18 Dec 2021 17:23:33 +0000 Original-Received: from localhost ([127.0.0.1]:43754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydQi-0005Vr-VG for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:23:33 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:34249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mydQd-0005VC-Ch for 52491@debbugs.gnu.org; Sat, 18 Dec 2021 12:23:27 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 9B161240002; Sat, 18 Dec 2021 17:23:20 +0000 (UTC) In-Reply-To: <4318fa2c-0127-4a14-f65e-399b5c097028@gmx.at> (martin rudalics's message of "Sat, 18 Dec 2021 10:05:50 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222615 Archived-At: > The bug is a regression so it should be fixed. Whether and how Juri's > fix can affect other operations that use the minibuffer before deleting > some window is beyond my imagination. Maybe it would be possible to change the default behavior of delete-window to do what it did in Emacs 27? But honestly, I don't understand how this old code managed to select the minibuffer after deleting the completions buffer and why its behavior differs after it was moved to Lisp: - /* Now look whether `get-mru-window' gets us something. */ - mru_window = call1 (Qget_mru_window, frame); - if (WINDOW_LIVE_P (mru_window) - && EQ (XWINDOW (mru_window)->frame, frame)) - new_selected_window = mru_window; - - /* If all ended up well, we now promote the mru window. */ - if (EQ (FRAME_SELECTED_WINDOW (f), selected_window)) - Fselect_window (new_selected_window, Qnil); - else - fset_selected_window (f, new_selected_window); > I do not understand two things: It seems that this part of the > doc-string > > A minibuffer window is never > a candidate when MINIBUF is nil or omitted. MINIBUF t means consider > the minibuffer window only if the minibuffer is active. > > does not match well this part of the code > > (dolist (window (window-list-1 nil (unless minibuf 'nomini) all-frames)) When MINIBUF is nil, ‘(unless minibuf 'nomini)’ is ‘'nomini’, when MINIBUF is non-nil, ‘(unless minibuf 'nomini)’ is ‘nil’, but the third possible value MINIBUF=‘t’ of window-list-1 is not used here. This value means consider the minibuffer window even if the minibuffer is not active. It seems this value is useless in get-mru-window for the purposes of delete-window? > And this (are we sure that we always want to do it when "setting up" > completions?) Another place would be completion-list-mode, but it's empty. > (setq-local delete-window-choose-selected 'mru) > > apparently makes this binding > > (choose-selected delete-window-choose-selected) > > necessary. But this would imply that at the time 'delete-window' is > called, its buffer is current which is by no means guaranteed. So the > latter form should probably become > > (choose-selected > (buffer-local-value > 'delete-window-choose-selected (window-buffer window)))) ‘buffer-local-value’ would be more correct, thanks.