From: Juri Linkov <juri@linkov.net>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 52286@debbugs.gnu.org
Subject: bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu
Date: Sat, 15 Jan 2022 20:57:39 +0200 [thread overview]
Message-ID: <86sfto25ek.fsf@mail.linkov.net> (raw)
In-Reply-To: <6faca77f-d732-d13e-2689-76e1e0943368@gmail.com> (Jim Porter's message of "Sat, 11 Dec 2021 12:52:16 -0800")
> It's not just for `elisp-mode'; any mode (or other third-party code) may
> want to insert context menu items in a certain spot. `middle-separator'
> follows the naming convention I recommend, but a hypothetical mode might
> want to insert a new item just after the separator for the Undo
> section. However, that's currently named `separator-undo' on master, so it
> can be confusing to remember the difference in naming between these two
> cases:
>
> (define-key-after menu [my-separator] menu-bar-separator
> 'middle-separator)
>
> (define-key-after menu [my-separator] menu-bar-separator
> 'separator-undo)
If it's too late to push this to the release branch,
then this definitely can't be done after the release.
So probably this bug report should be closed?
Meanwhile, I noticed another inconsistency
where context menus for some modes are named
with the -mode suffix, and some without it.
With `-mode':
lisp/help-mode.el
(defun help-mode-context-menu (menu click)
lisp/textmodes/text-mode.el
(defun text-mode-context-menu (menu click)
Without `-mode':
lisp/progmodes/prog-mode.el
(defun prog-context-menu (menu click)
lisp/progmodes/elisp-mode.el
(defun elisp-context-menu (menu click)
Maybe it's too late to fix this inconsistency too?
next prev parent reply other threads:[~2022-01-15 18:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 21:57 bug#52286: 28.0.90; [PATCH] Be consistent in naming of separators in context menu Jim Porter
2021-12-05 6:45 ` Eli Zaretskii
2021-12-05 7:44 ` Jim Porter
2021-12-05 10:39 ` Eli Zaretskii
2021-12-06 2:09 ` Jim Porter
2021-12-06 12:55 ` Eli Zaretskii
2021-12-11 20:52 ` Jim Porter
2022-01-15 18:57 ` Juri Linkov [this message]
2022-01-15 19:13 ` Eli Zaretskii
2022-01-15 19:19 ` Juri Linkov
2022-01-15 19:23 ` Eli Zaretskii
2022-01-15 19:25 ` Juri Linkov
2021-12-05 9:37 ` Juri Linkov
2021-12-05 17:52 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sfto25ek.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=52286@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).