From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#49534: [External] : Re: bug#49534: 26.3; Isearch should support using filter predicates with empty search hits Date: Wed, 16 Feb 2022 21:09:05 +0200 Organization: LINKOV.NET Message-ID: <86sfsiwrvy.fsf@mail.linkov.net> References: <86ee432hgf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20878"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: "49534@debbugs.gnu.org" <49534@debbugs.gnu.org> To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 16 20:11:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKPhp-0005I2-J2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Feb 2022 20:11:13 +0100 Original-Received: from localhost ([::1]:48304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKPho-0006aa-DA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 16 Feb 2022 14:11:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKPgg-0006a9-OL for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKPgg-0007pq-Dq for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nKPgg-0006jQ-3l for bug-gnu-emacs@gnu.org; Wed, 16 Feb 2022 14:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Feb 2022 19:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 49534-submit@debbugs.gnu.org id=B49534.164503858025841 (code B ref 49534); Wed, 16 Feb 2022 19:10:02 +0000 Original-Received: (at 49534) by debbugs.gnu.org; 16 Feb 2022 19:09:40 +0000 Original-Received: from localhost ([127.0.0.1]:49483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKPgK-0006ij-8H for submit@debbugs.gnu.org; Wed, 16 Feb 2022 14:09:40 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:57395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nKPgI-0006iW-Lb for 49534@debbugs.gnu.org; Wed, 16 Feb 2022 14:09:39 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 528CBC0009; Wed, 16 Feb 2022 19:09:30 +0000 (UTC) In-Reply-To: (Drew Adams's message of "Wed, 16 Feb 2022 18:54:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227052 Archived-At: >> All these changes fixed the test case that you >> presented in the bug report. > > Yes, I understand that. You've said that. > But that doesn't help me understand the code. > > Could you please answer the specific questions > I asked about the code? That will help me > understand what's going on. > > I'm in no way arguing that your fix is in some > way incorrect or insufficient. I'm just trying > to understand the code here. > > I'd appreciate this; thx. If I designed a new function from scratch then I could explain all decisions made while implementing it. But I only fixed a few places in the existing function just to pass test cases that you reported.