From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#55169: Can't combine window-min-height with window-height Date: Wed, 18 May 2022 21:20:05 +0300 Organization: LINKOV.NET Message-ID: <86sfp6d7oq.fsf@mail.linkov.net> References: <86y1zp5but.fsf@mail.linkov.net> <87czh0gp6m.fsf@gnus.org> <9753db0e-05f2-5927-80fb-50d17f16441d@gmx.at> <86czgxi3nn.fsf@mail.linkov.net> <86tua7pyfp.fsf@mail.linkov.net> <5e93dcad-4071-b4e2-d408-ba670413eb67@gmx.at> <868rriil03.fsf@mail.linkov.net> <0e9b53c4-b283-ca20-fa8a-995f2b58ed59@gmx.at> <865ymlje5o.fsf@mail.linkov.net> <8ae5e6ac-25f5-3feb-b05b-fbdb71e7ac1d@gmx.at> <864k24v0vo.fsf@mail.linkov.net> <865ymkrmze.fsf@mail.linkov.net> <86v8ujcd2r.fsf@mail.linkov.net> <3f7b273c-59f4-5486-728e-a0c8e09190a7@gmx.at> <86bkwahe5g.fsf@mail.linkov.net> <86mtfrj3bh.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17876"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 55169@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 18 20:23:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nrOKj-0004QM-Ef for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 May 2022 20:23:41 +0200 Original-Received: from localhost ([::1]:49336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nrOKi-0000EQ-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 May 2022 14:23:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nrOK7-00008T-1b for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 14:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39742) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nrOK6-0007CD-Gf for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 14:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nrOK6-0000UW-D9 for bug-gnu-emacs@gnu.org; Wed, 18 May 2022 14:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 May 2022 18:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55169 X-GNU-PR-Package: emacs Original-Received: via spool by 55169-submit@debbugs.gnu.org id=B55169.16528981471823 (code B ref 55169); Wed, 18 May 2022 18:23:02 +0000 Original-Received: (at 55169) by debbugs.gnu.org; 18 May 2022 18:22:27 +0000 Original-Received: from localhost ([127.0.0.1]:33638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrOJX-0000TK-Cd for submit@debbugs.gnu.org; Wed, 18 May 2022 14:22:27 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:56983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nrOJV-0000Sv-J9 for 55169@debbugs.gnu.org; Wed, 18 May 2022 14:22:25 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 9A8E740004; Wed, 18 May 2022 18:22:17 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Mon, 9 May 2022 09:24:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232600 Archived-At: > (defun shrink-window-if-larger-than-buffer (&optional window min-height) > "Shrink height of WINDOW if its buffer doesn't need so many lines. > More precisely, shrink WINDOW vertically to be as small as > possible, while still showing the full contents of its buffer. > WINDOW must be a live window and defaults to the selected one. > > The optional argument MIN-HEIGHT specifies the minimum number of > lines to which WINDOW may be shrunk and defaults to > `window-min-height'. > > Do nothing if the buffer contains more lines than the present > height of WINDOW, some of WINDOW's contents are scrolled out of > view, shrinking WINDOW would also shrink another window, or > WINDOW is the root window of its frame. > > Return non-nil if WINDOW was shrunk, nil otherwise." > (interactive) > (setq window (window-normalize-window window t)) > ;; Make sure that WINDOW is vertically combined and `point-min' is > ;; visible (for whatever reason that's needed). The remaining issues > ;; should be taken care of by `fit-window-to-buffer'. > (when (and (window-combined-p window) > (pos-visible-in-window-p (point-min) window)) > (let ((old-height (window-pixel-height window))) > (fit-window-to-buffer > window (window-total-height window) nil min-height) Thanks, this works fine, after removing nil above.