From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage Date: Wed, 10 Aug 2022 21:45:25 +0300 Organization: LINKOV.NET Message-ID: <86sfm4q6nu.fsf@mail.linkov.net> References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86bkssedll.fsf@mail.linkov.net> <87r11owlx4.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5222"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 10 21:13:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLr8z-0001G8-MJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 21:13:29 +0200 Original-Received: from localhost ([::1]:59710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLr8y-00086u-OJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 15:13:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLqjO-0006G9-Cq for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 14:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32780) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLqjO-0007R7-49 for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 14:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLqjN-00046k-TJ for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 14:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Aug 2022 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57082 X-GNU-PR-Package: emacs Original-Received: via spool by 57082-submit@debbugs.gnu.org id=B57082.166015718315746 (code B ref 57082); Wed, 10 Aug 2022 18:47:01 +0000 Original-Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 18:46:23 +0000 Original-Received: from localhost ([127.0.0.1]:50762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLqil-00045u-Iq for submit@debbugs.gnu.org; Wed, 10 Aug 2022 14:46:23 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLqik-00045d-1H for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 14:46:23 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 387E2C0002; Wed, 10 Aug 2022 18:46:11 +0000 (UTC) In-Reply-To: <87r11owlx4.fsf@gmx.net> (Stephen Berman's message of "Wed, 10 Aug 2022 10:19:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239317 Archived-At: >>>> `outline-minor-mode-highlight-buffer' is intended only for buffers >>>> that don't support font-lock highlighting. >>> >>> Yes, but with that change, arrows are displayed on first visiting the >>> NEWS buffer; without it, they only appear when typing TAB on an outline >>> heading. >> >> This change broke fontification e.g. in diff buffers that now >> add outline faces on diff hunks. So we need another solution. > > Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with > describe-binding). But do you have a recipe to see this? When I create > a diff with vc-diff I don't see outline faces on the hunks. The minimal test case is this: (setq-default outline-minor-mode-highlight t) (add-hook 'diff-mode-hook 'outline-minor-mode) Then the first lines of diff is highlighted with blue outline-1 face, the @@-lines with outline-2 face, etc. This is because outline-font-lock-keywords and outline-minor-mode-highlight-buffer have slightly different interpretations of the values for outline-minor-mode-highlight. This could be improved, but in any case both these functions should not be applied at the same time.