From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57813: Icon images are non-functional Date: Thu, 15 Sep 2022 19:36:52 +0300 Organization: LINKOV.NET Message-ID: <86sfks8uhn.fsf@mail.linkov.net> References: <86pmfxlp7s.fsf@mail.linkov.net> <861qsca9cn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1037"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) To: 57813@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 15 18:39:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYrtN-000Aeb-92 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 18:39:09 +0200 Original-Received: from localhost ([::1]:56028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oYrtM-0006fd-5i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Sep 2022 12:39:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYrtG-0006fA-Hd for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 12:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYrtG-00089H-AA for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 12:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oYrtG-00079d-5O for bug-gnu-emacs@gnu.org; Thu, 15 Sep 2022 12:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57813 X-GNU-PR-Package: emacs Original-Received: via spool by 57813-submit@debbugs.gnu.org id=B57813.166325991127456 (code B ref 57813); Thu, 15 Sep 2022 16:39:02 +0000 Original-Received: (at 57813) by debbugs.gnu.org; 15 Sep 2022 16:38:31 +0000 Original-Received: from localhost ([127.0.0.1]:59046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYrsk-00078m-MJ for submit@debbugs.gnu.org; Thu, 15 Sep 2022 12:38:30 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:38529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYrsi-00078X-1c for 57813@debbugs.gnu.org; Thu, 15 Sep 2022 12:38:29 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 0F062E000C for <57813@debbugs.gnu.org>; Thu, 15 Sep 2022 16:38:18 +0000 (UTC) In-Reply-To: <861qsca9cn.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 15 Sep 2022 19:30:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242616 Archived-At: --=-=-= Content-Type: text/plain >> So I tried this with 'C-h b', but images are displayed as black boxes. >> >> PS: "right.svg" exists in etc/images/right.svg. > > Fixed now in 471414fe6b. S-TAB is so slow that it takes several seconds on etc/NEWS. Here is an attempt to optimize it, so that it's almost instantaneous: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=outline--fix-up-all-buttons.patch diff --git a/lisp/outline.el b/lisp/outline.el index b19e0cf811..ff6eebcd1b 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -982,8 +989,6 @@ outline-hide-subtree (interactive (list last-nonmenu-event)) (when (mouse-event-p event) (mouse-set-point event)) - (when (outline--use-buttons-p) - (outline--insert-close-button)) (outline-flag-subtree t)) (defun outline--make-button-overlay (type) @@ -1051,9 +1056,12 @@ outline--fix-up-all-buttons ;; `outline--cycle-state' will fail if we're in a totally ;; collapsed buffer -- but in that case, we're not in a ;; `show-all' situation. - (if (eq (ignore-errors (outline--cycle-state)) 'show-all) - (outline--insert-open-button) - (outline--insert-close-button))) + (if (save-excursion + (outline-end-of-heading) + (seq-some (lambda (o) (eq (overlay-get o 'invisible) 'outline)) + (overlays-at (point)))) + (outline--insert-close-button) + (outline--insert-open-button))) (or from (point-min)) (or to (point-max))))) (define-obsolete-function-alias 'hide-subtree #'outline-hide-subtree "25.1") @@ -1076,8 +1084,6 @@ outline-show-subtree (interactive (list last-nonmenu-event)) (when (mouse-event-p event) (mouse-set-point event)) - (when (outline--use-buttons-p) - (outline--insert-open-button)) (outline-flag-subtree nil)) (define-obsolete-function-alias 'show-subtree #'outline-show-subtree "25.1") --=-=-=--