From: Juri Linkov <juri@linkov.net>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: 59141@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Abdul-Lateef Haji-Ali <abdo.haji.ali@gmail.com>,
yantar92@posteo.net
Subject: bug#59141: 28.1.90; Face :extend when all the line but trailing \n is invisible
Date: Sun, 20 Nov 2022 20:38:02 +0200 [thread overview]
Message-ID: <86sfidsbrx.fsf@mail.linkov.net> (raw)
In-Reply-To: <87cz9prxbg.fsf@gmail.com> ("Kévin Le Gouguec"'s message of "Mon, 14 Nov 2022 23:22:11 +0100")
> As I mentioned, magit supports replacing its fringe bitmaps with
> ellipses. See the magit-section-visibility-indicator user option, and
> the functions that act on it[1]. tl;dr the option can be set to
>
> * (SYMBOL1 . SYMBOL2): each symbol describes a fringe bitmap to be used
> for expandable (1) or collapsible (2) sections,
>
> * (STRING . BOOLEAN): STRING is appended at the end of collapsed
> sections.
>
> IIUC magit-section sets these ellipses via 'after-string overlays on the
> last character before a heading's newline, rather than adjusting display
> tables.
>
> Thanks for weighing in on how outline.el could be adapted, Juri. Can't
> promise I'll be able to act on your advice and turn it into a patch
> anytime soon, but finally hashing out the implementation details between
> these two packages has made me more hopeful outline.el can be taught
> more tricks without resorting to ugly hacks.
Thanks for summarizing the relevant details of magit-section.
Now everything is clear.
> (defun magit-section-maybe-paint-visibility-ellipses ()
> ;; This is needed because we hide the body instead of "the body
> ;; except the final newline and additionally the newline before
> ;; the body"; otherwise we could use `buffer-invisibility-spec'.
This comment explains why this is needed. I believe we could avoid
ugly hacks in outline.el because unlike magit-section, outline.el can
display arrows on the left side even on TTYs. But since the default
ellipses should be disabled in any case, even when users don't want to use
the left-side arrows, we could add ellipses in a more clean way: as a new
value of the user option 'outline-minor-mode-use-buttons'. So when it's
customized to 'ellipsis', the ellipsis overlay will be created in a new
pcase branch in outline--insert-button.
next prev parent reply other threads:[~2022-11-20 18:38 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 2:24 bug#59141: 28.1.90; Face :extend when all the line but trailing \n is invisible Ihor Radchenko
2022-11-09 7:49 ` Kévin Le Gouguec
2022-11-09 12:36 ` Eli Zaretskii
2022-11-09 17:12 ` Juri Linkov
2022-11-10 1:36 ` Ihor Radchenko
2022-11-10 7:45 ` Juri Linkov
2022-11-11 1:58 ` Ihor Radchenko
2022-11-11 7:46 ` Eli Zaretskii
2022-11-12 12:44 ` Ihor Radchenko
2022-11-11 8:13 ` Juri Linkov
2022-11-13 4:31 ` Ihor Radchenko
2022-11-11 12:30 ` Al Haji-Ali
2022-11-11 12:42 ` Eli Zaretskii
2022-11-11 16:00 ` Al Haji-Ali
2022-11-11 17:34 ` Eli Zaretskii
2022-11-11 19:47 ` Abdul-Lateef Haji-Ali
2022-11-11 20:09 ` Eli Zaretskii
2022-11-11 20:17 ` Abdul-Lateef Haji-Ali
2022-11-11 20:25 ` Eli Zaretskii
2022-11-12 11:18 ` Kévin Le Gouguec
2022-11-12 17:46 ` Juri Linkov
2022-11-13 10:50 ` Kévin Le Gouguec
2022-11-13 17:53 ` Juri Linkov
2022-11-13 22:22 ` Kévin Le Gouguec
2022-11-14 7:43 ` Juri Linkov
2022-11-14 11:02 ` Kévin Le Gouguec
2022-11-14 17:32 ` Juri Linkov
2022-11-14 17:44 ` Eli Zaretskii
2022-11-15 8:02 ` Juri Linkov
2022-11-15 14:42 ` Eli Zaretskii
2022-11-15 15:01 ` Ihor Radchenko
2022-11-15 15:05 ` Eli Zaretskii
2022-11-16 1:38 ` Ihor Radchenko
2022-11-16 13:01 ` Eli Zaretskii
2022-11-20 18:42 ` Juri Linkov
2022-11-14 22:22 ` Kévin Le Gouguec
2022-11-20 18:38 ` Juri Linkov [this message]
2022-11-22 7:52 ` Juri Linkov
2022-11-22 15:02 ` Eli Zaretskii
2022-11-22 17:35 ` Juri Linkov
2022-11-22 18:42 ` Eli Zaretskii
2022-11-22 19:16 ` Juri Linkov
2022-11-22 19:36 ` Eli Zaretskii
2022-11-12 17:52 ` Juri Linkov
2022-11-12 18:31 ` Eli Zaretskii
2024-01-25 22:53 ` Ihor Radchenko
2024-01-26 7:08 ` Eli Zaretskii
2022-11-09 12:29 ` Eli Zaretskii
2022-11-09 22:19 ` Kévin Le Gouguec
2022-11-10 7:10 ` Eli Zaretskii
2022-11-10 23:41 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sfidsbrx.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=59141@debbugs.gnu.org \
--cc=abdo.haji.ali@gmail.com \
--cc=eliz@gnu.org \
--cc=kevin.legouguec@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).