unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61535@debbugs.gnu.org
Subject: bug#61535: 29.0.60; choose-completion erases in-region buffer
Date: Sun, 19 Feb 2023 19:31:27 +0200	[thread overview]
Message-ID: <86sff1muj4.fsf@mail.linkov.net> (raw)
In-Reply-To: <83r0umydnm.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Feb 2023 21:30:37 +0200")

>> >> >> >> 1. type: (with-c C-M-i
>> >> >> >> 2. type: M-down ... M-RET
>>
>> 'M-RET' above is new.  It's bound to the new function
>> 'minibuffer-choose-completion' that let-binds
>> 'completion-use-base-affixes' to t that works
>> only in the minibuffer, not in 'completion-in-region-mode'.
>
> Sorry, I'm still confused.  The patch you want to install is
>
> diff --git a/lisp/simple.el b/lisp/simple.el
> index c58acfe3adc..1924567cc3f 100644
> --- a/lisp/simple.el
> +++ b/lisp/simple.el
> @@ -9882,7 +9882,8 @@ choose-completion
>        (with-current-buffer buffer
>          (choose-completion-string
>           choice buffer
> -         (or (and completion-use-base-affixes base-affixes)
> +         (or (and (not completion-in-region-mode)
> +                  completion-use-base-affixes base-affixes)
>               base-position
>               ;; If all else fails, just guess.
>               (list (choose-completion-guess-base-position choice)))
>
> But by default, completion-in-region-mode is t and
> completion-use-base-affixes is nil.  So this code is never executed in
> the recipe you posted, right?

M-RET is bound to minibuffer-choose-completion in completion-in-region-mode-map.
minibuffer-choose-completion let-binds completion-use-base-affixes to t
before calling choose-completion.  Therefore completion-use-base-affixes
should be ignored in choose-completion for completion-in-region-mode.

> Moreover, if I look at buffer-undo-list, I don't think I see there
> that the entire buffer text of *scratch* was deleted and recreated.
>
> So what am I missing, and what is the problem you are trying to fix?

Here is the output of 'C-h v buffer-undo-list' after typing M-RET
in the *scratch* buffer:

  buffer-undo-list is a variable defined in ‘C source code’.

  Its value is shown below.

  Value:
  (nil
   (1 . 166)
   (#(";; This buffer is for text that is not saved, and for Lisp evaluation.
  ;; To create a file, visit it with C-x C-f and enter text in its buffer.

  (with-c" 0 3
  ...





  reply	other threads:[~2023-02-19 17:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 18:32 bug#61535: 29.0.60; choose-completion erases in-region buffer Juri Linkov
2023-02-15 19:35 ` Eli Zaretskii
2023-02-16 17:51   ` Juri Linkov
2023-02-16 20:09     ` Eli Zaretskii
2023-02-17  7:50       ` Juri Linkov
2023-02-17  8:37         ` Eli Zaretskii
2023-02-18 18:43           ` Juri Linkov
2023-02-18 19:30             ` Eli Zaretskii
2023-02-19 17:31               ` Juri Linkov [this message]
2023-02-19 18:35                 ` Eli Zaretskii
2023-02-19 19:32                   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86sff1muj4.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=61535@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).