From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Thu, 22 Feb 2024 21:04:35 +0200 Message-ID: <86sf1k1fss.fsf@gnu.org> References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17552"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69232@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 22 20:08:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdEQL-0004KU-NT for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Feb 2024 20:08:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdEQ1-0003gF-Tq; Thu, 22 Feb 2024 14:07:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdEPz-0003fc-9L for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 14:07:39 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdEPy-00024Q-Sb for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 14:07:39 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdEQL-00010F-KR for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 14:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Feb 2024 19:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.17086288403754 (code B ref 69232); Thu, 22 Feb 2024 19:08:01 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 22 Feb 2024 19:07:20 +0000 Original-Received: from localhost ([127.0.0.1]:50788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdEPf-0000yS-Ig for submit@debbugs.gnu.org; Thu, 22 Feb 2024 14:07:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdEPb-0000xs-QV for 69232@debbugs.gnu.org; Thu, 22 Feb 2024 14:07:18 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdEN3-0001TC-Im; Thu, 22 Feb 2024 14:04:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G7WUch+HGfMEnAXJMXv3Yccy+seKfCLD2jWxz+3nNoE=; b=CuYOFB33zVtL oGk27wclC2vMpLvie1GqT8x0PAhCnloivTHkEc12ONwtLZNBT0gOvsLn2yav2xIyHi/bbBnmUs3J/ Rk427S3rMUWPJsP2Au+Fx5UDJOdUxZfgfP6AcxxPgSBKbQYAqlCS9iED2s/lo0FCvZ+2m450LS46f BkZVh5noWH+qTrX6hg8iRwk1Yh1rTU3KPAGvYYljBxNKHl+zrPYuBZIejUdF2+Jh4aXZhf+Buk2R7 CwIJ6H3Np99tChkgCcheIM61G8GNASFQlk6yXzylroeTVbn92xwPIkkLvtoh9abCfIGEjP5OoP7Hl RAEkvtuzCcK7fNR/ZMk5Ng==; In-Reply-To: <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> (message from Jim Porter on Thu, 22 Feb 2024 09:18:47 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280467 Archived-At: > Date: Thu, 22 Feb 2024 09:18:47 -0800 > Cc: 69232@debbugs.gnu.org > From: Jim Porter > > On 2/22/2024 5:22 AM, Eli Zaretskii wrote: > >> Date: Mon, 19 Feb 2024 10:55:49 -0800 > >> Cc: 69232@debbugs.gnu.org > >> From: Jim Porter > >> > >> On 2/19/2024 4:12 AM, Eli Zaretskii wrote: > >>> I'm not sure this is a bug fix, and I think this behavior change does > >>> need a NEWS entry. > >> > >> Ok, I added one. > > > > Thanks, but I'm afraid it's somewhat confusing: > > > >> +*** History navigation in EWW now works like other browsers. > >> +Previously, when navigating back and forward through page history in > >> +EWW, new history entries could get added to the history list. Now, when > >> +navigating through history, EWW preserves the history list and only > >> +displays the relevant history entry. > > > > This doesn't really explain the nature of the change in behavior. > > AFAIU, the previous behavior was that going back in browsing history > > could add the old entries to the history instead of removing them; now > > going back will _never_ add entries to the history. Isn't that so? > > In other browsers, you only add new entries to the back/forward history > when you go to a totally new page (e.g. by clicking a link). If you just > go back or forward, you should only change your position in the > already-existing history. That's (roughly) what EWW does with the patch, > with the exception that a new page doesn't go into the history immediately. > > Previously, every time you went back or forward, it added entries to the > end of the history list. > > How does this look? It is IMO still not clear enough about the behavior change. It looks like you are describing what the old implementation did and the new one will do, instead of describing the behavior as it the user will see it. Can you instead describe the change in terms of user-facing behavior?