From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Thu, 18 Apr 2024 19:24:06 +0300 Message-ID: <86sezid4gp.fsf@gnu.org> References: <86y19ad61t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15548"; mail-complaints-to="usenet@ciao.gmane.io" Cc: felician.nemeth@gmail.com, 70036@debbugs.gnu.org, theo@thornhill.no To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 18 18:26:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxUaT-0003sX-Oq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Apr 2024 18:26:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxUaQ-0000fx-5b; Thu, 18 Apr 2024 12:26:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxUaG-0000fJ-J6 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:26:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxUa6-00017Q-6p for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:25:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxUaJ-0006H8-M9 for bug-gnu-emacs@gnu.org; Thu, 18 Apr 2024 12:26:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Apr 2024 16:26:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171345750423709 (code B ref 70036); Thu, 18 Apr 2024 16:26:03 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 18 Apr 2024 16:25:04 +0000 Original-Received: from localhost ([127.0.0.1]:53331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxUZL-0006A3-8H for submit@debbugs.gnu.org; Thu, 18 Apr 2024 12:25:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxUZI-000695-AC for 70036@debbugs.gnu.org; Thu, 18 Apr 2024 12:25:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxUYx-0000kn-Kx; Thu, 18 Apr 2024 12:24:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=LJoZY2gJBoFzVR05QuK7Wu+ZARh0QumHtX1xTLDgDv0=; b=j63JScZX4X90/P7rWV/f zdYvtKSSB/UBEll0IWbC14orgzlQ5edWuFfUdOXknbvFpy86aiOZa0D+KHa5RjyyUQ5fTbOTmGAHL FZtDpSww4lb9SlcVw3xbvbRQyW4GN0rqdA15VSlGfn1ykFIQsUvQblnXgrDdTs8V8tM58Irsim971 i3Atnm01YusZEhuBPW2aQoGad7Wx7zmdn2ftwSXpOKGuDZo75wde0l7Jf1j4SgJPN9GYxtiPk3xJM Jm1KrKTNWVYa4dQtdnfRIXdH5mcqclLQQT4tpBmGT4t7Ne7mpmJc1uMXCy/ATC5UhYMm7C+AIpVqF gszS16ksL4OTGQ==; In-Reply-To: (message from =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= on Thu, 18 Apr 2024 17:12:34 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283586 Archived-At: > From: João Távora > Date: Thu, 18 Apr 2024 17:12:34 +0100 > Cc: theo@thornhill.no, felician.nemeth@gmail.com, 70036@debbugs.gnu.org > > > Profiles can mislead and they can lie. > > Theo's profiles attached to this issue were the best I could find. > If the manner in which they were collected was enough to make a > decision in a certainway, they should be good enough to make a decision > in another way. > > But I fully agree we should have a more constrained test case. > > > It is much easier to time the > > old and the new code doing the same jobs, and compare the times. > > So... that's what I did. If you timed this code with the likes of benchmark-run, please show the timings. Profiles are not the best instrument for this kind of decisions. > Do you have a concrete idea of what this "job" is? No, sorry. If nothing else comes to mind, I think Theo had such a scenario. > Of course. Let's have Theo do this comparison and perhaps describe > in more detail the conditions in which he collected his profiles Sure, it doesn't matter who does the measurements, as long as we have them.