From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70415: 30.0.50; [Cygwin] `lock-file' creates a symlink with funny name Date: Sun, 05 May 2024 08:40:53 +0300 Message-ID: <86seyweryy.fsf@gnu.org> References: <861q75juvy.fsf@gnu.org> <86zftsgoxt.fsf@gnu.org> <86frv3r32m.fsf@gnu.org> <3a7eea72-d4ab-4fde-bdad-71b5e8f5bb7f@cornell.edu> <86le4uq0tj.fsf@gnu.org> <26ab8055-1da6-4b3e-a65c-68c598cb7660@cornell.edu> <86zft8n37z.fsf@gnu.org> <618931e0-ad26-4d07-b9c6-8563831a9fb8@cornell.edu> <867cg9fpzv.fsf@gnu.org> <9e83bbd4-13a7-4495-a9dc-d9ad181b5c09@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29538"; mail-complaints-to="usenet@ciao.gmane.io" Cc: yamaoka@jpl.org, 70415@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 05 07:42:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3UdW-0007WR-G0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 May 2024 07:42:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3UdA-00048k-A8; Sun, 05 May 2024 01:41:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3Ud6-00048Q-09 for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 01:41:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3Ud0-00063B-Vj for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 01:41:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3UdO-0000un-Bs for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 01:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2024 05:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70415 X-GNU-PR-Package: emacs Original-Received: via spool by 70415-submit@debbugs.gnu.org id=B70415.17148876913509 (code B ref 70415); Sun, 05 May 2024 05:42:02 +0000 Original-Received: (at 70415) by debbugs.gnu.org; 5 May 2024 05:41:31 +0000 Original-Received: from localhost ([127.0.0.1]:57786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Uct-0000uX-57 for submit@debbugs.gnu.org; Sun, 05 May 2024 01:41:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Ucq-0000uP-R3 for 70415@debbugs.gnu.org; Sun, 05 May 2024 01:41:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3UcL-0005ln-3S; Sun, 05 May 2024 01:40:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=kwNQrr0gDSgSJXDIZab/dAKLDPY2nGM3MWsF9m34xJI=; b=dMyz2h4TAnQjsPFmqNAU qi5U/BEepUdL4U67kFEekN+MW2wpg+X/bJhRcuBu+rvSs6psgXIfqjyw6II0jvh9XJVVbs2/nZh+m zCuNH0fXF8XlF02ssRwxxBB6vWxbUZuNUDBVcEo1dWUiu56kmi5shNoIX/3JrYur+kagH/4ALhhpq tqVbU5b4kFGnwW+Q199n0FL535pREIgw3zGH9ynHsuUu7Zz1pM9GXcnZ3HO+tjKW2Da0FW3us8CIZ 0bGNd3IK9LQwJMMUYRbzsVE0+c1EkS0qnuOgmUtT+e930UrOVPzryGqaj9CWSM9fLdWItmJKsmiuY B08HHwmCQcUBjA==; In-Reply-To: <9e83bbd4-13a7-4495-a9dc-d9ad181b5c09@cornell.edu> (message from Ken Brown on Sat, 4 May 2024 18:01:25 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284482 Archived-At: > Date: Sat, 4 May 2024 18:01:25 -0400 > From: Ken Brown > Cc: yamaoka@jpl.org, 70415@debbugs.gnu.org > > > Not only was the system's page file deemed to be a directory, but it was > > deemed to have a negative modification time.  I think that's where the > > dash came from.  But I don't know why that prevented the lock file from > > being deleted. > > I found the answer: filelock.c:current_lock_owner returns an error if > the colon exists and is not followed by a digit. See filelock.c:421. Right. Does the below look like the right change to support such weird cases? diff --git a/src/filelock.c b/src/filelock.c index 01d35c4..86c6eeb 100644 --- a/src/filelock.c +++ b/src/filelock.c @@ -419,7 +419,9 @@ current_lock_owner (lock_info_type *owner, Lisp_Object lfname) boot += 2; FALLTHROUGH; case ':': - if (! c_isdigit (boot[0])) + if (! c_isdigit (boot[0]) + /* A negative number. */ + || (boot[0] == '-' && c_isdigit (boot[1]))) return EINVAL; boot_time = strtoimax (boot, &lfinfo_end, 10); break;