* bug#70795: 30.0.50; inconsistent warning-display-at-bottom display-buffer-alist behavior
@ 2024-05-06 6:06 Gerard Vermeulen
2024-05-06 6:46 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Gerard Vermeulen @ 2024-05-06 6:06 UTC (permalink / raw)
To: 70795
Hi,
if I set warning-display-at-bottom to nil and do
(add-to-list 'display-buffer-alist
`(,(rx (or "*Warnings*" "*compilation*"))
display-buffer-no-window
(allow-no-window . t)))
then warnings are added to the hidden *Warnings* buffer.
But if I set warning-display-at-bottom to t, then I get an
window-live-p related error with the display-buffer-alist
setting above.
This bug is related to #70773 where Prot reports a similar
problem in a somewhat different context.
Juri Linkov proposed a patch which he retracted, but maybe
his patch solves the inconsistency reported here.
Regards -- Gerard
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#70795: 30.0.50; inconsistent warning-display-at-bottom display-buffer-alist behavior
2024-05-06 6:06 bug#70795: 30.0.50; inconsistent warning-display-at-bottom display-buffer-alist behavior Gerard Vermeulen
@ 2024-05-06 6:46 ` Juri Linkov
2024-05-06 17:00 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2024-05-06 6:46 UTC (permalink / raw)
To: Gerard Vermeulen; +Cc: 70795
> (add-to-list 'display-buffer-alist
> `(,(rx (or "*Warnings*" "*compilation*"))
> display-buffer-no-window
> (allow-no-window . t)))
>
> then warnings are added to the hidden *Warnings* buffer.
This is because this case doesn't set 'warning-series',
so when window is nil, it doesn't fail at anoter place
while calling 'set-window-start':
(when (and (markerp warning-series)
(eq (marker-buffer warning-series) buffer))
(set-window-start window warning-series))
Ok, I will add only checks for nil window.
But won't add (allow-no-window . t) to the caller of
'display-buffer' in 'display-warning' to not encourage
hiding the warning buffer.
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#70795: 30.0.50; inconsistent warning-display-at-bottom display-buffer-alist behavior
2024-05-06 6:46 ` Juri Linkov
@ 2024-05-06 17:00 ` Juri Linkov
0 siblings, 0 replies; 3+ messages in thread
From: Juri Linkov @ 2024-05-06 17:00 UTC (permalink / raw)
To: Gerard Vermeulen; +Cc: 70795
forcemerge 70773 70795
close 70795 30.0.50
thanks
>> (add-to-list 'display-buffer-alist
>> `(,(rx (or "*Warnings*" "*compilation*"))
>> display-buffer-no-window
>> (allow-no-window . t)))
>>
>> then warnings are added to the hidden *Warnings* buffer.
>
> This is because this case doesn't set 'warning-series',
> so when window is nil, it doesn't fail at anoter place
> while calling 'set-window-start':
>
> (when (and (markerp warning-series)
> (eq (marker-buffer warning-series) buffer))
> (set-window-start window warning-series))
>
> Ok, I will add only checks for nil window.
> But won't add (allow-no-window . t) to the caller of
> 'display-buffer' in 'display-warning' to not encourage
> hiding the warning buffer.
So now pushed the extra guards for windows.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-06 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-06 6:06 bug#70795: 30.0.50; inconsistent warning-display-at-bottom display-buffer-alist behavior Gerard Vermeulen
2024-05-06 6:46 ` Juri Linkov
2024-05-06 17:00 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).