From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70725: 29.3; dired-do-touch completion Date: Sat, 18 May 2024 11:43:14 +0300 Message-ID: <86seyfecil.fsf@gnu.org> References: <871q6kkn5o.fsf@librehacker.com> <87plu38pf6.fsf@posteo.net> <86fruzjudh.fsf@gnu.org> <87fruzwetu.fsf@posteo.net> <8634qwlrii.fsf@mail.linkov.net> <87v83r8pm3.fsf@posteo.net> <86msp38lqm.fsf@mail.linkov.net> <87r0ef8cr9.fsf@posteo.net> <87seyv6ulx.fsf@igel.home> <87msp386vn.fsf@posteo.net> <86zft1h8jt.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: christopher@librehacker.com, schwab@linux-m68k.org, 70725@debbugs.gnu.org To: thievol@posteo.net, Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 18 10:44:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s8Fft-0002lw-Vb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 May 2024 10:44:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8Ffl-00011N-SJ; Sat, 18 May 2024 04:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8Ffe-00010r-Iw for bug-gnu-emacs@gnu.org; Sat, 18 May 2024 04:44:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s8Ffb-0005Xk-5k for bug-gnu-emacs@gnu.org; Sat, 18 May 2024 04:44:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s8Ffe-0007gC-FW for bug-gnu-emacs@gnu.org; Sat, 18 May 2024 04:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 May 2024 08:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70725 X-GNU-PR-Package: emacs Original-Received: via spool by 70725-submit@debbugs.gnu.org id=B70725.171602181529504 (code B ref 70725); Sat, 18 May 2024 08:44:02 +0000 Original-Received: (at 70725) by debbugs.gnu.org; 18 May 2024 08:43:35 +0000 Original-Received: from localhost ([127.0.0.1]:60371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8FfD-0007fo-8y for submit@debbugs.gnu.org; Sat, 18 May 2024 04:43:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8FfA-0007fi-R3 for 70725@debbugs.gnu.org; Sat, 18 May 2024 04:43:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8Fev-0005S9-To; Sat, 18 May 2024 04:43:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JGKCe4tLZ7HpuvSK/pgxCzKmXmlDtVvBB6UEC3YclyI=; b=ESuaplwYR/kk DVtMUP2EcqYBiehiTO+EIb28f/qfv/sPKC4IgdUJoDhvPMQWRiglFmI0B4uizUVjBw5EuulzotSFF sBEtWXd65RPvEWLflhRzPwqClARYlsxVMHgzN7G7ux9iMwgJfBmuOYsGhdy5DFpJC3j0xF6/VHKkt YhyAWyiYJPgXJAT8IXTcuwz/ke2Fjk5mqkTwuUIK+dej6UA5vxaei8dN0s5bM4IHgJXI4xN5MoWJS 93rZqqQx4E8x5qR3LnNWu2ttTuH8LDx7am8es4yZFHNS5ge5kOGnVvKRt5/7NxGLmn3QDebz0K/Pr a3Dz4a9/BlOhtcyUZYz2sA==; In-Reply-To: <86zft1h8jt.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 07 May 2024 19:48:54 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285298 Archived-At: > From: Juri Linkov > Cc: Andreas Schwab , christopher@librehacker.com, > Eli Zaretskii , 70725@debbugs.gnu.org > Date: Tue, 07 May 2024 19:48:54 +0300 > > > However this doesn't explain why dired-do-touch uses a completing-read > > Indeed, this was an oversight. Here is the patch > that replaces 'completing-read' with 'read-string': Thierry, is this solution okay with you? > diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el > index a2ce3083cfe..f3343b9b637 100644 > --- a/lisp/dired-aux.el > +++ b/lisp/dired-aux.el > @@ -658,10 +658,13 @@ dired-mark-read-string > > Optional arg COLLECTION is a collection of possible completions, > passed as the second arg to `completing-read'." > - (dired-mark-pop-up nil op-symbol files > - 'completing-read > - (format prompt (dired-mark-prompt arg files)) > - collection nil nil initial nil default-value nil)) > + (apply #'dired-mark-pop-up > + nil op-symbol files > + (if (eq op-symbol 'touch) 'read-string 'completing-read) > + (format prompt (dired-mark-prompt arg files)) > + (if (eq op-symbol 'touch) > + `(,initial nil ,default-value nil) > + `(,collection nil nil ,initial nil ,default-value nil)))) > > > ;;; Cleaning a directory: flagging some backups for deletion