From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71070: 30.0.50; c++-ts-mode namespace wrong fontification. Date: Mon, 20 May 2024 14:11:21 +0300 Message-ID: <86seycagbq.fsf@gnu.org> References: <87h6et6550.fsf.ref@aol.com> <87h6et6550.fsf@aol.com> <86wmnpabu0.fsf@gnu.org> <86v839aa3a.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18270"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 71070@debbugs.gnu.org To: Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 20 13:12:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s90wD-0004Xq-CF for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 May 2024 13:12:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s90vx-0007HK-Dv; Mon, 20 May 2024 07:12:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s90vv-0007H7-Jc for bug-gnu-emacs@gnu.org; Mon, 20 May 2024 07:11:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s90vt-0000FY-RT for bug-gnu-emacs@gnu.org; Mon, 20 May 2024 07:11:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s90vy-0000Ws-4u for bug-gnu-emacs@gnu.org; Mon, 20 May 2024 07:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 May 2024 11:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71070 X-GNU-PR-Package: emacs Original-Received: via spool by 71070-submit@debbugs.gnu.org id=B71070.17162035002026 (code B ref 71070); Mon, 20 May 2024 11:12:02 +0000 Original-Received: (at 71070) by debbugs.gnu.org; 20 May 2024 11:11:40 +0000 Original-Received: from localhost ([127.0.0.1]:42073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s90vb-0000Wc-MT for submit@debbugs.gnu.org; Mon, 20 May 2024 07:11:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s90vX-0000WS-Do for 71070@debbugs.gnu.org; Mon, 20 May 2024 07:11:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s90vM-0000B9-QP; Mon, 20 May 2024 07:11:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mws7XaDqLV7v83se2Ko//J7VUsBVCwRcwt2T9lwkQe0=; b=N1EiFsLBnTl5 zM40Xl64AlI4J/yx8uGL0OgC+wEmm3eNz4h4jdGWe8tg4lLFuebqZXNGANvX8gXnkF6JzWmEYTo+1 GQirQINgWO/UsPDHU3a8J/f72aQA6bH8iQ1mgCuBM27810n8tqolXzTyhdc8yw9dbG0bh5Rn29+59 EQaze8OtvGhurdhckAvD6gNUYakdlsiIAHNQmlDCK+zO3eFe/+82yYW2lxpjgD+tqOmL9qh8PxXoj YM1hdgKfvYq0glJTidpTKxB9Y7mOlTgVx2OAzVg/mE8XeargmnNjAGDjCk5+vpmV9b8ztyDF3f5yr rQaO+W2HZSFx124pkm1eGw==; In-Reply-To: (message from Ergus on Sun, 19 May 2024 23:36:41 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285472 Archived-At: > Date: Sun, 19 May 2024 23:36:41 +0200 > From: Ergus > Cc: casouri@gmail.com, 71070@debbugs.gnu.org > > On Sun, May 19, 2024 at 10:13:45PM GMT, Eli Zaretskii wrote: > >No one said that what c++-mode does is necessarily correct. maybe it > >is, maybe it isn't. > > > >How do other C++ IDEs fontify namespace names? > > Hi Eli: > > Every editor-ide has its own approach for this. But emacs has it own > flavor and the ts-* intention was to keep it as close as possible to the > status-quo; that's why I am reporting it here. > > There are many details missing in the c/c++-ts-mode compared to > c-mode... but I understand that some of them are WIP while others are > just too complex to port. I understand all that, but still: can you (or someone else) answer my question about the accepted practices of IDEs in this matter: do they highlight the namespace identifiers differently than other identifiers, or do they use the same highlighting? It is IMO important to know what are the accepted practices, to deal with this issue in a proper perspective. > My main concern here is that this seemed like a simple issue considering > that treesitter recognizes the namespace correctly. But the Yuan's fix > didn't work; so maybe there is a detail we are missing here, or that > needs extra documentation? Or in the worst case some detail/issue broken > in the ts api? I don't know. In particular, I don't know what specific aspects of this did Yuan try to fix. Yuan is CC'ed and will hopefully chime in and answer these questions. Meanwhile we should make up our minds regarding the desired behavior, which is mostly independent of what Yuan tried to do and even of what c++-mode does. Thanks.