From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Thu, 27 Jun 2024 11:41:22 +0300 Message-ID: <86sewy6aml.fsf@gnu.org> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <875y4oaban.fsf@whxvd.name> <83bkeg4o1u.fsf@gnu.org> <87o7ifu2v8.fsf@localhost> <838r9j339x.fsf@gnu.org> <87tts78lve.fsf@whxvd.name> <87zg1u0yrp.fsf@whxvd.name> <8334zmrmnu.fsf@gnu.org> <87o7eew0is.fsf@whxvd.name> <83mstiu9c3.fsf@gnu.org> <87wmmlowuv.fsf@localhost> <86h6dlic82.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19668"; mail-complaints-to="usenet@ciao.gmane.io" Cc: acorallo@gnu.org, 65734-done@debbugs.gnu.org, monnier@iro.umontreal.ca To: yantar92@posteo.net, iota@whxvd.name, Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 10:42:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMki2-0004vN-CE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 10:42:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMkhf-0003Ox-2r; Thu, 27 Jun 2024 04:42:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkhc-0003Lj-5c for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 04:42:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMkhb-0002kp-Kh for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 04:41:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMkhe-0007iE-C7 for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 04:42:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 08:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65734 X-GNU-PR-Package: emacs Mail-Followup-To: 65734@debbugs.gnu.org, eliz@gnu.org, iota@whxvd.name Original-Received: via spool by 65734-done@debbugs.gnu.org id=D65734.171947769929610 (code D ref 65734); Thu, 27 Jun 2024 08:42:02 +0000 Original-Received: (at 65734-done) by debbugs.gnu.org; 27 Jun 2024 08:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:40948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkhG-0007hW-PX for submit@debbugs.gnu.org; Thu, 27 Jun 2024 04:41:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMkhF-0007hH-G9 for 65734-done@debbugs.gnu.org; Thu, 27 Jun 2024 04:41:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMkh4-0002j5-Sh; Thu, 27 Jun 2024 04:41:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fY01LPAdRlri58ymNb7gH2D8ImYFjdrFMQcQx4j7uX4=; b=K5z0qMUtraVk Gh9wcChZ4TBfA//FWg+T6Mk0dL2orJAhfOZCLo6FmNdcLaUKx33DBwWQXbFn1n7r1SGcrJAiFoPxW WWogr65AtzP0XunFteh+hE0oHLSVojLra3H02Ty5sYD4YwrdUJppoz7/RUuU1syy5dBl2bx3fGi8I mDHy34w1ggHwd5gvjOnhnww/J9q81M+C3oZ9IuSIM5f9S9NFn3HtQVvAdOaVMwWgy1kydibfD2DaL gM0FLWQFl3nOgxxe13TcIEALf3YEZeKLOjkaB9KhHeq81RQLuX4rS6oUQe1qsOdl35ZBBtosLsp7M ZL2Y9PJzfEiI/73AU0f5AQ==; In-Reply-To: (message from Stefan Kangas on Sat, 22 Jun 2024 12:00:26 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287997 Archived-At: > From: Stefan Kangas > Date: Sat, 22 Jun 2024 12:00:26 -0700 > Cc: iota@whxvd.name, monnier@iro.umontreal.ca, 65734@debbugs.gnu.org, > Andrea Corallo > > Eli Zaretskii writes: > > >> From: Ihor Radchenko > >> Cc: Sebastian Miele , Stefan Monnier > >> , Stefan Kangas , > >> 65734@debbugs.gnu.org > >> Date: Wed, 19 Jun 2024 14:01:12 +0000 > >> > >> Eli Zaretskii writes: > >> > >> > The patches lack suitable ChangeLog-style commit log messages (see > >> > CONTRIBUTE for details and you can use "git log" to show examples of > >> > how we do this). > >> > > >> > I'd also ask Stefan Monnier and Stefan Kangas to review the patch, > >> > since this is an important command and I would like to avoid breaking > >> > it. > >> > >> Please see the attached edited patches with proper commit messages. > > > > Stefan, Stefan and Andrea, could you please review this? If you see > > no problems, let's install this in Emacs 30. > > The patch and proposed behavior makes sense to me. Thanks, I've now installed this on the emacs-30 branch, and I'm closing the bug. Btw, the new tests broke simple-tests (because they caused packages be loaded that affected the completion tested by one of the tests. I fixed that, but please always run the relevant test files whenever you modify them, don't assume that adding or modifying a test will never affect other tests in the same file.