From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72616: 30.0.60; M-x apropos-library eglot fails Date: Wed, 14 Aug 2024 15:14:28 +0300 Message-ID: <86sev78fob.fsf@gnu.org> References: <86y14z8o7v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12057"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72616@debbugs.gnu.org, gerard.vermeulen@posteo.net, joaotavora@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 14 14:18:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1seCx8-0002x0-G7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Aug 2024 14:18:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1seCwv-0001ho-76; Wed, 14 Aug 2024 08:17:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seCwd-0001cn-Jy for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 08:17:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1seCwR-0008Hv-T2 for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 08:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=Rx0KJDkrIv7UME6Yo0pD9w2GKsgDk2LphlP+McGwJfc=; b=adzgFXKPO1gmgM4gzxDUpz15zRqOwP3SqPVq0Ztm+mCpvQB3te8y+dLDES0NiPseact8QGvQrz9JfTtHw8Iq6nfsCR8mwlBC1Tddch3UbzNgMdy5/TEFwR4bqRieZ1yqy0U0990bQHvMujtuqxkxLlwF3U3vNclnqoV0F7uFd+PihibPJGPMN7jxl77WzA7d1a06cNE6QI51hSAU8AZ8ROC+I2TeMNB+Vn1xmDJVl1dbrjehjwM5mAC7wAeBbVypWy3dwEeoAiFqE+jkEYP2iHdYbv0lw6Xz+neofatKwVBAfDULLu55c/ayLqgjnw2ClU7rXzGp+630c0LxnNdW4A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1seCx0-0002JN-J8 for bug-gnu-emacs@gnu.org; Wed, 14 Aug 2024 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Aug 2024 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72616 X-GNU-PR-Package: emacs Original-Received: via spool by 72616-submit@debbugs.gnu.org id=B72616.17236378558841 (code B ref 72616); Wed, 14 Aug 2024 12:18:02 +0000 Original-Received: (at 72616) by debbugs.gnu.org; 14 Aug 2024 12:17:35 +0000 Original-Received: from localhost ([127.0.0.1]:46412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seCwY-0002IX-Kj for submit@debbugs.gnu.org; Wed, 14 Aug 2024 08:17:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seCwW-0002IJ-K6 for 72616@debbugs.gnu.org; Wed, 14 Aug 2024 08:17:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seCtm-0007du-71; Wed, 14 Aug 2024 08:14:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Rx0KJDkrIv7UME6Yo0pD9w2GKsgDk2LphlP+McGwJfc=; b=MCpjTQonKfr6ct5tZoAi g7GoiFNYWXbP9TKweRIRdwa5a3BBrAkoH+U1kec20TlojhHCC2p4L8ShmgVt0dLWVTHcH9CNhC+am US45/V18bB0YvIy7Rr60Uh83SfGG3VHJjGhSuHpsytdsoDI1qvcWZJssCG+BbGDwdLKmT9lXCmWCi COxDu5vW4iNaffHc9dDmNPEfIzZeI6hvgTqlBmA4sq12GNBwagD0V5USWvj0o7bqTUOX8PfPjN/1+ HVG/BurD7aWGvu7bF5H8tPOygrvFWhdAOmDZUeXN023IWVpK4wKRtB4XwCUlZBlXmyeJ0qXXBUMhP tr4Ki9GCmHZS7g==; In-Reply-To: (message from Stefan Monnier on Wed, 14 Aug 2024 07:58:15 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290135 Archived-At: > From: Stefan Monnier > Cc: Gerard Vermeulen , Joćo Tįvora > , 72616@debbugs.gnu.org > Date: Wed, 14 Aug 2024 07:58:15 -0400 > > >> I get the message: > >> "apropos-library: Wrong type argument: symbolp, ((cl-deftype-satisfies > >> eglot-lsp-server))" > >> when I try "M-x apropos-library eglot" > > > > You forgot to tell that one needs first to load Eglot, otherwise the > > above command cannot be invoked at all. > > > > Stefan and Joćo, is the below the right solution? > > > > diff --git a/lisp/apropos.el b/lisp/apropos.el > > index 6c6cd0b..3fb7581 100644 > > --- a/lisp/apropos.el > > +++ b/lisp/apropos.el > > @@ -731,6 +731,7 @@ apropos-library > > ('require (push (cdr x) requires)) > > ('provide (push (cdr x) provides)) > > ('t nil) ; Skip "was an autoload" entries. > > + ('define-symbol-props nil) > > ;; FIXME: Print information about each individual method: both > > ;; its docstring and specializers (bug#21422). > > ('cl-defmethod (push (cadr x) provides)) > > This doesn't look right: the meaning of `define-symbol-props` in > `load-history` should be defined in a more modular way, near > `define-symbol-prop` rather than by hardcoding something in > `apropos.el`. Is it better to leave us where we are now: that apropos-library signals an error instead of displaying the information about the library? > IOW, we should add something to `apropos.el` where users of > `load-history` can register what to do with their entries, just like > `find-function-regexp-alist` and the generic function > `loadhist-unload-element` are used to tell `find-function` what to do > with those same entries. Patches are welcome, but maybe we should start with someone explaining what are those define-symbol-props elements in load-history. They are currently completely undocumented AFAICT, and so anyone but the person(s) who added that to Emacs will have hard time coming up with changes such as you describe. (Apologies if this is already documented and I just missed it.)