From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: i@fuzy.me, 73801@debbugs.gnu.org
Subject: bug#73801: 31.0.50; project-try-vc sometimes set wrong cache project-vc-extra-root-markers
Date: Tue, 29 Oct 2024 15:33:36 +0200 [thread overview]
Message-ID: <86sesf58zz.fsf@gnu.org> (raw)
In-Reply-To: <1a2ab2c3-272a-41c8-af6f-6ed7348189df@gutov.dev> (message from Dmitry Gutov on Tue, 29 Oct 2024 04:44:13 +0200)
> Date: Tue, 29 Oct 2024 04:44:13 +0200
> From: Dmitry Gutov <dmitry@gutov.dev>
> Cc: Zhengyi Fu <i@fuzy.me>
>
> Since I see some changes added to the release branch still,
>
> On 28/10/2024 06:06, Dmitry Gutov wrote:
> > It would be nice to get either of the patches into Emacs 30, too, but it
> > might be a little late given where it is in the pretest.
>
> Eli, could we install either of the fixes for this bug to emacs-30 too?
>
> The one I installed on master is longer but should result in less I/O,
> while the patch by Zhengyi Fu is a one-liner, which might feel a little
> safer.
I don't understand the implications of that one-line (nor, TBH, the
analysis of the original problem), so I'm not sure these changes are
safe. How do we know that catering to this corner case will not screw
other corner cases? It isn't the first time project.el needs to
tiptoe between several valid outcomes using some pretty ad-hoc
heuristic.
next prev parent reply other threads:[~2024-10-29 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 6:29 bug#73801: 31.0.50; project-try-vc sometimes set wrong cache project-vc-extra-root-markers Zhengyi Fu
2024-10-27 10:31 ` Eli Zaretskii
2024-10-28 4:06 ` Dmitry Gutov
2024-10-29 2:44 ` Dmitry Gutov
2024-10-29 13:33 ` Eli Zaretskii [this message]
2024-10-29 20:31 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86sesf58zz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73801@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=i@fuzy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).