From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74235: [PATCH] ; Remove 'nil' from some 'lua-ts-mode' options Date: Fri, 08 Nov 2024 17:24:04 +0200 Message-ID: <86ses1oijv.fsf@gnu.org> References: <8734k4xdon.fsf@pub.pink> <87ses4vyzp.fsf@pub.pink> <86y11vr3e5.fsf@gnu.org> <87ldxtn57i.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74235@debbugs.gnu.org To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 08 16:27:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9QtM-0001Y7-1q for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Nov 2024 16:27:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9Qt7-0007l8-Ts; Fri, 08 Nov 2024 10:27:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9Qt6-0007kG-7B for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2024 10:27:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9Qt5-00033N-OG for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2024 10:27:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=bBbdNjGOskS5lZJ6WweDbWqicaDo2iZ98E/3JpJzZ0s=; b=MJJlBaS+Ud6lXF8ig1bEQH1WISg2R14PNU+kgjV6CpKXiNIlocHRPgNE///KShkb37uyNZa9+yo0mVz8nOKSwH0Fnb1eUfe8hK/G8XDvhENSt7Qt0u390Ade9osqok9QSpezBq8LOuvvdSDkuvaI8kQmUhYhg7eDvzmKikb4a0tqh2q+xZX/jDRF8Kb2+36HVYNrR/NMg1fb0nXlM8mHNk2NJEFcNA2yDs0Eae1dWYBYwssKnKX+StjiKvu3TDXZniS+o6xSeumXbsoiXmK2SF7qV7MdYtO7XJvwFDe4Bo8l2Z6Zw8b5w3s2a++VpWFPRsFZbrDHqOMAsxzAOxUSMg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9Qt5-0003pD-Im for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2024 10:27:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Nov 2024 15:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74235 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74235-submit@debbugs.gnu.org id=B74235.173107960514642 (code B ref 74235); Fri, 08 Nov 2024 15:27:03 +0000 Original-Received: (at 74235) by debbugs.gnu.org; 8 Nov 2024 15:26:45 +0000 Original-Received: from localhost ([127.0.0.1]:51732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9Qsn-0003o6-AA for submit@debbugs.gnu.org; Fri, 08 Nov 2024 10:26:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9Qsl-0003ns-Aj for 74235@debbugs.gnu.org; Fri, 08 Nov 2024 10:26:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9QqY-0002Zp-Vp; Fri, 08 Nov 2024 10:24:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bBbdNjGOskS5lZJ6WweDbWqicaDo2iZ98E/3JpJzZ0s=; b=fDW2G01I0jYh6WNfpPPq 2xQNmYxXjvxjPg+T/eyjNPMu4t1saH5kLKIRdwEkhgqr8ELysWoLNro20+GgkElji1tjXZ2JE30p8 nIGTm9ZGkcE3kJqemGAT8Ph73VsUC241qEz8IJ1suUXWI5nQER+CjUpnGK4ded9nD39c6SN1RqY33 G4A5zEDqMtHMmbn8QwyzzIjgCR/AwTdhXmBJzb2bdkfQDrJtedwMVacofVgaTgfGo1sinKXWL+xu2 Zey4EL0B2B8CGJm91gPZu2E9mXrhewBbJJH9Ozs3pr4z+3K1rL0lTNZEE71QezJ/0CGL1hTys6ATl EGIgE3M6ibG4IQ==; In-Reply-To: <87ldxtn57i.fsf@pub.pink> (message from john muhl on Fri, 08 Nov 2024 08:57:37 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295072 Archived-At: > From: john muhl > Cc: 74235@debbugs.gnu.org > Date: Fri, 08 Nov 2024 08:57:37 -0600 > > Eli Zaretskii writes: > > >> From: john muhl > >> Date: Wed, 06 Nov 2024 15:22:34 -0600 > >> > >> * lisp/progmodes/lua-ts-mode.el (lua-ts-luacheck-program): > >> (lua-ts-inferior-program): Remove 'nil' as it is never a valid > >> choice. (Bug#74235) > > > > IMO, the use of these options in the code is not clean: if these > > programs are not installed, the commands which reference these options > > will signal errors whose diagnostic might not clearly indicate the > > root cause. I would like to see a cleaner handling of such > > contingencies by this mode. Does this make sense, and if so, would > > you like to suggest changes to that effect? > > The only idea I’ve come up with so far is showing a warning that > mentions the incorrectly set option. Does that sound like what you > have in mind? If not I’d appreciate some more explicit guidance. How about signaling user-error from the commands that invoke those programs, when they are missing?