unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>
Cc: acorallo@gnu.org, stefankangas@gmail.com, 74946@debbugs.gnu.org
Subject: bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too
Date: Fri, 20 Dec 2024 08:46:12 +0200	[thread overview]
Message-ID: <86seqikg23.fsf@gnu.org> (raw)
In-Reply-To: <87frmjtl9f.fsf@> (message from Björn Bidar on Thu, 19 Dec 2024 23:29:00 +0200)

> From: Björn Bidar <bjorn.bidar@thaodan.de>
> Cc: Stefan Kangas <stefankangas@gmail.com>,  74946@debbugs.gnu.org,
>   acorallo@gnu.org
> Date: Thu, 19 Dec 2024 23:29:00 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > It looks innocent enough, but at this point I'd like to limit changes
> > on the release branch to only really urgent and important ones (or
> > documentation).  We have lived with this outdated code for several
> > years (GDB 11.1 was released in 2022), so this change doesn't look
> > urgent to me.
> 
> Not really that urgent but to new users of Emacs it would be
> beneficial if things would work out of the box. I thought at first Emacs
> just didn't support the file.

I understand, but my main worry is the potential unintended
consequences.  Regexps are tricky, as we all know.

> > Btw, if we want to fix this entry, we should perhaps do a more
> > thorough job.  For example, on my system I have files with the
> > following base names:
> >
> >   .gdbinit.in
> >   .gdbinit
> >   _gdbinit (for MS-DOS)
> >   gdb.ini (likewise)
> 
> Is this a gdbinit file? The extension looks off.

Yes, gdb.ini is a gdbinit file.  But if supporting it is problematic
or causes too many complications, I'm okay with not supporting that
particular file name.

> >   gdbinit
> >   gdbinit.in
> >   SOMETHING-gdbinit
> >   .gdbinit.loader
> >   gdbinit-history.exp (not a GDB init file)
> >   gdbinit.5 (likewise)
> >   gdbinit.c (likewise)
> >   .gdbinit.py.in (likewise)
> >
> > Should we improve the regexp to DTRT for those additional files, but
> > without false positives?
> 
> With Stefan correction all these without extension match. What are the
> official extensions? gdbinit.in sounds like a normal extension for
> gdbinit template in the source but the others such as gdb.ini look off.

So we should at least allow the ".in" extension?  Also, note that the
current regexp doesn't end with a \\' so it could be a partial match
with, say, /foo/bar/gdbinit-but-not-really.





  parent reply	other threads:[~2024-12-20  6:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-18 14:19 bug#74946: [PATCH] * lisp/files.el (auto-mode-alist): Include gdbinit too Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-19  1:00 ` Stefan Kangas
2024-12-19  8:14   ` Eli Zaretskii
2024-12-19 21:29     ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-19 22:55     ` Stefan Kangas
2024-12-20  1:33       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-20  7:05       ` Eli Zaretskii
     [not found]     ` <87frmjtl9f.fsf@>
2024-12-20  6:46       ` Eli Zaretskii [this message]
2024-12-20  8:07         ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86seqikg23.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74946@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).