bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support

bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support

[Andrew De Angelis]

[-- Attachment #1.1: Type: text/plain, Size: 861 bytes --]

Hello everyone.

I have a question and a possible patch to contribute.
For context: the most glaring issues with xwidget support of NS have been
fixed: I contributed a patch to get rid of memory leaks a while ago, under:
"bug#60703 Patches to xwidget code".

I've just noticed that I forgot to update the TODO file, so it still
mentions crashes:
> trying to display a xwidget in the "killed" state will make Emacs crash.

I've used the xwidget feature extensively and in my experience, xwidgets do
not crash Emacs anymore.

Question:
 - Could someone clarify what we mean by displaying a xwidget in the
"killed" state? I want to make sure I understand the problem and it's fixed

Possible patch (if the problem is indeed fixed):
Attached. Remove the mention of crashes, and clarify which features are
still missing from the NS port.


Thanks for all your work!

[-- Attachment #1.2: Type: text/html, Size: 1142 bytes --]

[-- Attachment #2: update-todo-for-xwidget-ns.patch --]
[-- Type: application/octet-stream, Size: 1011 bytes --]

diff --git a/etc/TODO b/etc/TODO
index f9918fede38..fa19d9f96d9 100644
--- a/etc/TODO
+++ b/etc/TODO
@@ -955,13 +955,13 @@ This sections contains features found in other official Emacs ports.
 Emacs 25 has support for xwidgets, a system to include WebKit widgets
 into an Emacs buffer.
 
-They work on NS, but not very well.  For example, trying to display a
-xwidget in the "killed" state will make Emacs crash.  This is because
-the NS code has not been updated to keep with recent changes to the
-X11 and GTK code.
+They work on NS, but not very well.  This is because the NS code has
+not been updated to keep with recent changes to the X11 and GTK code.
 
-Many features such as xwidget-webkit-edit-mode do not work correctly
-on NS either.
+Many features do not work correctly on NS, such as:
+ - xwidget-webkit-edit-mode
+ - xwidget-webkit-isearch-mode
+ - xwidget-webkit-browse-history.
 
 **** Respect 'frame-inhibit-implied-resize'
 When the variable 'frame-inhibit-implied-resize' is non-nil, frames

bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support

[Eli Zaretskii]

> From: Andrew De Angelis <bobodeangelis@gmail.com>
> Date: Sun, 10 Nov 2024 10:13:17 -0500
> 
> I have a question and a possible patch to contribute.
> For context: the most glaring issues with xwidget support of NS have been fixed: I contributed a patch to get
> rid of memory leaks a while ago, under: "bug#60703 Patches to xwidget code".
> 
> I've just noticed that I forgot to update the TODO file, so it still mentions crashes:
> > trying to display a xwidget in the "killed" state will make Emacs crash.
> 
> I've used the xwidget feature extensively and in my experience, xwidgets do not crash Emacs anymore.
> 
> Question:
>  - Could someone clarify what we mean by displaying a xwidget in the "killed" state? I want to make sure I
> understand the problem and it's fixed

Can someone who knows about this (Po Lu?) answer Andrew's question?

> Possible patch (if the problem is indeed fixed):
> Attached. Remove the mention of crashes, and clarify which features are still missing from the NS port.

I installed that on the emacs-30 release branch, thanks.

bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support

[Eli Zaretskii]

Ping!

> Cc: 74295@debbugs.gnu.org
> Date: Thu, 14 Nov 2024 10:22:21 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Andrew De Angelis <bobodeangelis@gmail.com>
> > Date: Sun, 10 Nov 2024 10:13:17 -0500
> > 
> > I have a question and a possible patch to contribute.
> > For context: the most glaring issues with xwidget support of NS have been fixed: I contributed a patch to get
> > rid of memory leaks a while ago, under: "bug#60703 Patches to xwidget code".
> > 
> > I've just noticed that I forgot to update the TODO file, so it still mentions crashes:
> > > trying to display a xwidget in the "killed" state will make Emacs crash.
> > 
> > I've used the xwidget feature extensively and in my experience, xwidgets do not crash Emacs anymore.
> > 
> > Question:
> >  - Could someone clarify what we mean by displaying a xwidget in the "killed" state? I want to make sure I
> > understand the problem and it's fixed
> 
> Can someone who knows about this (Po Lu?) answer Andrew's question?
> 
> > Possible patch (if the problem is indeed fixed):
> > Attached. Remove the mention of crashes, and clarify which features are still missing from the NS port.
> 
> I installed that on the emacs-30 release branch, thanks.
> 
> 
> 
> 

bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support

[Eli Zaretskii]

Ping! Ping!  Po Lu, can you please answer Andrew's question, if you
know the answer?

> Cc: bobodeangelis@gmail.com, 74295@debbugs.gnu.org
> Date: Sat, 30 Nov 2024 11:46:19 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> Ping!
> 
> > Cc: 74295@debbugs.gnu.org
> > Date: Thu, 14 Nov 2024 10:22:21 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > > From: Andrew De Angelis <bobodeangelis@gmail.com>
> > > Date: Sun, 10 Nov 2024 10:13:17 -0500
> > > 
> > > I have a question and a possible patch to contribute.
> > > For context: the most glaring issues with xwidget support of NS have been fixed: I contributed a patch to get
> > > rid of memory leaks a while ago, under: "bug#60703 Patches to xwidget code".
> > > 
> > > I've just noticed that I forgot to update the TODO file, so it still mentions crashes:
> > > > trying to display a xwidget in the "killed" state will make Emacs crash.
> > > 
> > > I've used the xwidget feature extensively and in my experience, xwidgets do not crash Emacs anymore.
> > > 
> > > Question:
> > >  - Could someone clarify what we mean by displaying a xwidget in the "killed" state? I want to make sure I
> > > understand the problem and it's fixed
> > 
> > Can someone who knows about this (Po Lu?) answer Andrew's question?
> > 
> > > Possible patch (if the problem is indeed fixed):
> > > Attached. Remove the mention of crashes, and clarify which features are still missing from the NS port.
> > 
> > I installed that on the emacs-30 release branch, thanks.
> > 
> > 
> > 
> > 
> 
> 
> 
> 

bug#74295: Update TODO -> NeXTstep port -> Improved xwidgets support

[Eli Zaretskii]

Ping! Ping! Ping! Po Lu, please respond.

> Cc: bobodeangelis@gmail.com, 74295@debbugs.gnu.org
> Date: Sat, 14 Dec 2024 11:32:36 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> Ping! Ping!  Po Lu, can you please answer Andrew's question, if you
> know the answer?
> 
> > Cc: bobodeangelis@gmail.com, 74295@debbugs.gnu.org
> > Date: Sat, 30 Nov 2024 11:46:19 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > Ping!
> > 
> > > Cc: 74295@debbugs.gnu.org
> > > Date: Thu, 14 Nov 2024 10:22:21 +0200
> > > From: Eli Zaretskii <eliz@gnu.org>
> > > 
> > > > From: Andrew De Angelis <bobodeangelis@gmail.com>
> > > > Date: Sun, 10 Nov 2024 10:13:17 -0500
> > > > 
> > > > I have a question and a possible patch to contribute.
> > > > For context: the most glaring issues with xwidget support of NS have been fixed: I contributed a patch to get
> > > > rid of memory leaks a while ago, under: "bug#60703 Patches to xwidget code".
> > > > 
> > > > I've just noticed that I forgot to update the TODO file, so it still mentions crashes:
> > > > > trying to display a xwidget in the "killed" state will make Emacs crash.
> > > > 
> > > > I've used the xwidget feature extensively and in my experience, xwidgets do not crash Emacs anymore.
> > > > 
> > > > Question:
> > > >  - Could someone clarify what we mean by displaying a xwidget in the "killed" state? I want to make sure I
> > > > understand the problem and it's fixed
> > > 
> > > Can someone who knows about this (Po Lu?) answer Andrew's question?
> > > 
> > > > Possible patch (if the problem is indeed fixed):
> > > > Attached. Remove the mention of crashes, and clarify which features are still missing from the NS port.
> > > 
> > > I installed that on the emacs-30 release branch, thanks.
> > > 
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> 
> 
> 
>