From: Nicolas Graner <nicolas.graner@universite-paris-saclay.fr>
To: 43218@debbugs.gnu.org
Subject: bug#43218: EWW handles default answer incorrectly when changing a select
Date: Sat, 05 Sep 2020 12:44:52 +0200 [thread overview]
Message-ID: <86r1rgv6xn.fsf@hypra-xx> (raw)
When you type <RET> on a "select" input in EWW, you are prompted for a
new value in the minibuffer. If you just type <RET> to the prompt, the
selected value should remain unchanged. Instead, the value is replaced
with an empty string, which effectively make the select disappear.
Explanation: the function eww-change-select calls:
(completing-read "Change value: " options nil 'require-match)
without providing a default value, and uses its return value unconditionally. If the user just types <RET>, that return value is an empty string.
To fix it, the code should either pass the currently selected value as the DEF argument to completing-read, or ignore the return value when it is empty.
Nicolas
next reply other threads:[~2020-09-05 10:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 10:44 Nicolas Graner [this message]
2020-09-05 13:51 ` bug#43218: EWW handles default answer incorrectly when changing a select Lars Ingebrigtsen
2020-09-05 17:18 ` Nicolas Graner
2020-09-05 23:59 ` Lars Ingebrigtsen
2020-09-06 1:55 ` Stefan Monnier
2020-09-06 11:48 ` Lars Ingebrigtsen
2020-09-06 12:29 ` Nicolas Graner
2020-09-06 12:35 ` Lars Ingebrigtsen
2020-09-06 14:40 ` Eli Zaretskii
2020-09-06 14:41 ` Lars Ingebrigtsen
2020-09-06 14:57 ` Eli Zaretskii
2020-09-06 17:05 ` Lars Ingebrigtsen
2020-09-06 17:56 ` Nicolas Graner
2020-09-06 19:32 ` Lars Ingebrigtsen
2020-09-06 17:06 ` Drew Adams
2020-09-06 17:12 ` Lars Ingebrigtsen
2020-09-06 17:18 ` Drew Adams
2020-09-06 17:26 ` Lars Ingebrigtsen
2020-09-06 18:57 ` Stefan Monnier
2020-09-06 22:49 ` Lars Ingebrigtsen
2020-09-06 22:56 ` Lars Ingebrigtsen
2020-09-06 4:41 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r1rgv6xn.fsf@hypra-xx \
--to=nicolas.graner@universite-paris-saclay.fr \
--cc=43218@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).