From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#19479: Package manager vulnerable Date: Mon, 07 Sep 2020 10:14:52 -0400 Message-ID: <86r1rd65cz.fsf@gmail.com> References: <87k11pnap2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38234"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (windows-nt) Cc: 19479@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 07 16:16:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFHwI-0009qR-DW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 16:16:10 +0200 Original-Received: from localhost ([::1]:58710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFHwH-0006xc-8G for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Sep 2020 10:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45114) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFHwA-0006xW-Mn for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 10:16:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFHwA-0005iK-E7 for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 10:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFHwA-0001WH-9V for bug-gnu-emacs@gnu.org; Mon, 07 Sep 2020 10:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Sep 2020 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19479 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 19479-submit@debbugs.gnu.org id=B19479.15994881055767 (code B ref 19479); Mon, 07 Sep 2020 14:16:02 +0000 Original-Received: (at 19479) by debbugs.gnu.org; 7 Sep 2020 14:15:05 +0000 Original-Received: from localhost ([127.0.0.1]:50331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHvF-0001Uw-Lu for submit@debbugs.gnu.org; Mon, 07 Sep 2020 10:15:05 -0400 Original-Received: from mail-qt1-f180.google.com ([209.85.160.180]:39291) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHvE-0001UA-15 for 19479@debbugs.gnu.org; Mon, 07 Sep 2020 10:15:04 -0400 Original-Received: by mail-qt1-f180.google.com with SMTP id h6so2090254qtd.6 for <19479@debbugs.gnu.org>; Mon, 07 Sep 2020 07:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=/XfAXtaP02Te/4EOgoy88Vgm/AyNIoG2YoEOxfj/jq8=; b=dMxs7mFqHYgRyM0979s8cPdab95kv+SGrKsmLYG3oztv1HixrkApe5PzYu3a9KbEIz NRAhfl9cb3eSGIPXx4+BYZi7DD5dU9yWVLCk5n7bXBT+b/LLrfMG/A/dh41trweZKfbC X7m2ND1gr2cuX5dwwI63IdQtuo+emFplDaBncr3Nhjs7Zqi0T3bsZcnICv0/2TsVIxXr TvG+jKuSGHnMZ3+n/lvCSY+jsGlOB5ZR9TZDPy9xx90m5HMO5ndDxrH+s9mc/YKg9zJU a0M7f2kyvEM6W4Ojkk/aWbiuxKGZE7RHULXg4vh6L0tGGaI/xxSXthvhEzUaBoZuaBdg RfiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=/XfAXtaP02Te/4EOgoy88Vgm/AyNIoG2YoEOxfj/jq8=; b=SN2llGJJzVf+28j5xq2FDLKQcLwEVTD7qp5ZCyuDD0zUSj/Vbu48pRWp+sTUF5YkoI WIFrtLX08B/BQ2K9arwyQ/PPSsANlSDSpa/h/c3Snv9eFhQ0QPSR8qu2NCAvFbnN+b4S bEZDqqCHkdIKJaSm7ABNSUbe5MwZLZSRukFD8lA7PpChvTxNhVru42zIssS7RvOOvUpC V2ZbL6lty5F7Xt4cDH9hR4cQE9CJF+Gx2qV6T6VGrlq9gnOPKyTOlBAthDYkRXaLZE/Q FdaS73dl27oaUyKq0QFxuPJrZpjfVOx4wFPbUVTsBOLGmsDHZhqkAh8Flg2nbsCWhouJ 8ioA== X-Gm-Message-State: AOAM531t5JhRXSAUChit1+UlyOurB4JIJmwiQYLgOF39aY90ouQzBNgq lU4v0Arn5N8zPAtvoIHZUFabZOvWfziPTg== X-Google-Smtp-Source: ABdhPJzoD4RCMSUtEJcL/gDs6Jd9BfPmO5AS+Th8Ho2xtH8ZxnLyvG3jMjjV3614a78vwOa0FNS2kQ== X-Received: by 2002:ac8:ecb:: with SMTP id w11mr20313811qti.373.1599488098273; Mon, 07 Sep 2020 07:14:58 -0700 (PDT) Original-Received: from LAPTOP-5NDQIUP9 (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id n186sm5183604qkd.107.2020.09.07.07.14.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Sep 2020 07:14:57 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Sun, 6 Sep 2020 16:59:48 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187433 Archived-At: Stefan Kangas writes: >> Is this a function (rather than a variable) just so it can be in the >> same cl-flet* as do-check? > > I'm not sure I understand; it should be a function instead of a variable > because there is logic in there to match `(secure-hash-algorithms)' > against `(package-desc-checksums pkg-desc)' and signal an error. Ah, I think had forgotten about/was confused by cl-flet's (FUNC (lambda ARGLIST ...)) syntax when I wrote that. Although I suppose you could make it a plain variable by moving it inside do-check's lambda (not sure if that's an improvement)?