From: Andy Moreton <andrewjmoreton@gmail.com>
To: 51497@debbugs.gnu.org
Subject: bug#51497: 29.0.50; (vc-print-log) broken over TRAMP
Date: Sat, 06 Nov 2021 22:11:03 +0000 [thread overview]
Message-ID: <86r1btvsso.fsf@gmail.com> (raw)
In-Reply-To: <877ddv9ue0.fsf@jpl.nasa.gov>
On Sat 06 Nov 2021, Eli Zaretskii wrote:
>> Cc: lists@dima.secretsauce.net, 51497@debbugs.gnu.org, larsi@gnus.org,
>> wolfgang.scherer@gmx.de
>> From: Dmitry Gutov <dgutov@yandex.ru>
>> Date: Sat, 6 Nov 2021 22:44:55 +0300
>>
>> > I'm a bit worried by the function relying on the fact that
>> > default-directory is the directory of the repository. Wouldn't it be
>> > better to explicitly let-bind it inside the function?
>>
>> We could, but notice how most of vc-git-* functions don't bind
>> default-directory, thus relying on its implicit value. It just how VC
>> works: expecting default-directory to have the right value around the calls.
>
> How certain are you that default-directory has the right value?
> Because if it doesn't, AFAIU all the connection-specific stuff will
> fall apart.
>
>> > A (perhaps safer) alternative for emacs-28 would be not to use
>> > :(literal) for remote repositories. What are the disadvantages of
>> > that?
>>
>> That would mean leaving bug#39452 unfixed on remote hosts.
>
> Only for files with wildcard characters in their names. How
> frequently does that happen? Also, it will be only unsolved in Emacs
> 28.
I missed the discussion in bug#39452 at the time, but while the solution
was being worked on, I used advice to stub out the literal pathspec
functions:
(advice-add 'vc-git--literal-pathspec :override #'identity)
(advice-add 'vc-git--literal-pathspecs :override #'identity)
That workaround is still needed for me. Without that, nothing in vc-git
works in my environment (64bit minw64 build on win10, using cygwin bash
and git together with cygwin-mount.el from emacs wiki).
While I realise my setup is somewhat non-standard, other users may also
find that the literal pathspec code also misbehaves.
AndyM
next prev parent reply other threads:[~2021-11-06 22:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 1:24 bug#51497: 29.0.50; (vc-print-log) broken over TRAMP dima
2021-10-30 12:48 ` Lars Ingebrigtsen
2021-10-30 13:21 ` Dmitry Gutov
2021-10-30 19:01 ` Dima Kogan
2021-10-31 0:56 ` Dmitry Gutov
2021-10-31 6:58 ` Dima Kogan
2021-10-31 8:16 ` Michael Albinus
2021-10-31 12:26 ` Dmitry Gutov
2021-10-31 16:05 ` Michael Albinus
2021-11-03 2:00 ` Dmitry Gutov
2021-11-03 17:09 ` Michael Albinus
2021-11-05 2:00 ` Dmitry Gutov
2021-11-03 2:03 ` Dmitry Gutov
2021-11-03 3:03 ` Dima Kogan
2021-11-03 12:06 ` Dmitry Gutov
2021-11-06 13:22 ` Dmitry Gutov
2021-11-06 15:51 ` Eli Zaretskii
2021-11-06 19:44 ` Dmitry Gutov
2021-11-06 19:52 ` Eli Zaretskii
2021-11-06 22:11 ` Andy Moreton [this message]
2021-11-06 22:21 ` Dmitry Gutov
2021-11-06 23:03 ` Andy Moreton
2021-11-07 0:11 ` Dmitry Gutov
2021-11-07 6:47 ` Eli Zaretskii
2021-11-07 10:43 ` Andy Moreton
2021-11-07 22:36 ` Dmitry Gutov
2021-11-08 12:49 ` Eli Zaretskii
2021-11-08 17:30 ` Dmitry Gutov
2021-11-08 18:18 ` Eli Zaretskii
2021-12-23 10:28 ` Lars Ingebrigtsen
2021-12-26 0:53 ` Dmitry Gutov
2021-12-27 1:36 ` Dmitry Gutov
2022-01-03 3:59 ` Dmitry Gutov
2022-01-03 21:15 ` Dima Kogan
2022-01-03 22:51 ` Dmitry Gutov
2022-01-04 3:28 ` Eli Zaretskii
2022-01-05 2:09 ` Dmitry Gutov
2022-01-21 13:50 ` Lars Ingebrigtsen
2022-01-21 14:11 ` Dmitry Gutov
2022-01-03 21:16 ` Andy Moreton
2021-11-07 6:43 ` Eli Zaretskii
2021-11-07 10:45 ` Andy Moreton
2021-11-07 6:31 ` Eli Zaretskii
2021-11-06 22:19 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r1btvsso.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=51497@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).