From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Sun, 14 Nov 2021 21:46:33 +0200 Organization: LINKOV.NET Message-ID: <86r1bisep2.fsf@mail.linkov.net> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <865ysuy56x.fsf@mail.linkov.net> <8735nymsxm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4190"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51809@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 14 20:48:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mmLUA-0000u4-4Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 20:48:18 +0100 Original-Received: from localhost ([::1]:35768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmLU8-0000qH-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Nov 2021 14:48:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmLTu-0000q5-DV for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 14:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40215) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmLTu-00018D-4o for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 14:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mmLTt-00063q-St for bug-gnu-emacs@gnu.org; Sun, 14 Nov 2021 14:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Nov 2021 19:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.163691927523281 (code B ref 51809); Sun, 14 Nov 2021 19:48:01 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 14 Nov 2021 19:47:55 +0000 Original-Received: from localhost ([127.0.0.1]:51760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmLTn-00063Q-GY for submit@debbugs.gnu.org; Sun, 14 Nov 2021 14:47:55 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:36709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mmLTk-00062u-Lg for 51809@debbugs.gnu.org; Sun, 14 Nov 2021 14:47:53 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 58E17240007; Sun, 14 Nov 2021 19:47:44 +0000 (UTC) In-Reply-To: <8735nymsxm.fsf@gmail.com> (Matthias Meulien's message of "Sun, 14 Nov 2021 20:35:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220007 Archived-At: >> Something strange happened recently with diff-mode and outline-minor-mode. >> I can't use this combination anymore. While reading your patches, I'm trying >> to type TAB on the hunk header to hide already viewed hunks of your patch. >> But TAB does nothing now. Do you see the same? TAB is used to hide/show body >> when outline-minor-mode-cycle is t. > > I've observed too that `outline-minor-mode-cycle' didn't worked well in > `diff-mode' buffers but I never saw it working! > > Since I am used to hitting TAB to go to next button or for completion, > and I am used to the horrible `outline-minor-mode-prefix' bindings, my > feeling is that TAB was a bad choice for this, and I didn't try to > debug: I just turned off `outline-minor-mode-cycle'... TAB is not a problem when `outline-minor-mode-cycle-filter' is customized to allow outline's TAB only on some parts of the outline heading, e.g. only at the beginning, or everywhere except the beginning of the diff hunk line. Then typing TAB everywhere else will go to the next button. > Do you have `diff-font-lock-prettify' enabled? I remember the situation > was better without this, not sure... Nope, `diff-font-lock-prettify' is disabled.