From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51016: 28.0.50; 'diff-font-lock-prettify' breaks display of outline headers Date: Fri, 19 Nov 2021 10:31:09 +0200 Organization: LINKOV.NET Message-ID: <86r1bcpo5i.fsf@mail.linkov.net> References: <87bl44qz5o.fsf@gmail.com> <87wnmgk6r7.fsf@gmail.com> <87tugrmi1j.fsf@gnus.org> <86pmqxuymw.fsf@mail.linkov.net> <87ee7cwqwj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37191"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Matthias Meulien , 51016@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 19 09:40:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnzRQ-0009U6-4o for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 09:40:16 +0100 Original-Received: from localhost ([::1]:35996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnzRO-0002EA-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Nov 2021 03:40:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnzRD-0002DS-8l for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 03:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnzRC-00067t-WC for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 03:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnzRC-00071B-Gi for bug-gnu-emacs@gnu.org; Fri, 19 Nov 2021 03:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Nov 2021 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51016 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51016-submit@debbugs.gnu.org id=B51016.163731118726953 (code B ref 51016); Fri, 19 Nov 2021 08:40:02 +0000 Original-Received: (at 51016) by debbugs.gnu.org; 19 Nov 2021 08:39:47 +0000 Original-Received: from localhost ([127.0.0.1]:37937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnzQx-00070e-2J for submit@debbugs.gnu.org; Fri, 19 Nov 2021 03:39:47 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:54665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnzQg-0006zN-Sp for 51016@debbugs.gnu.org; Fri, 19 Nov 2021 03:39:46 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 54D4124000B; Fri, 19 Nov 2021 08:39:24 +0000 (UTC) In-Reply-To: <87ee7cwqwj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 19 Nov 2021 08:22:52 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220387 Archived-At: > Juri Linkov writes: > >> As noticed in bug#51809, outline-cycle is not bound on hunk headings anymore, >> only on file headings. It seems the problem is somewhere here: >> >> (setq diff-outline-regexp >> (concat "\\(^diff --git.*\n\\|" diff-hunk-header-re "\\)")) >> >> But I don't know why diff-hunk-header-re doesn't match hunk headings >> in outline-minor-mode. > > Hm... I just tried switching outline-minor-mode on and > (re-search-forward diff-hunk-header-re), and it seemed to work as > expected? Yep, I already tried `(re-search-forward diff-hunk-header-re)' too, and it works. But still typing TAB on the hunk heading with outline-minor-mode-cycle=t does nothing, whereas typing TAB on the file heading correctly cycles the file diff.