From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60285: xref-query-replace-in-results could show an arrow pointing to the current item being replaced Date: Mon, 16 Jan 2023 19:39:38 +0200 Organization: LINKOV.NET Message-ID: <86r0vu2xb9.fsf@mail.linkov.net> References: <86v8ll2kk3.fsf@mail.linkov.net> <5ada9b8c-8ec6-d31c-8133-462a577727ad@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2838"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 60285@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 16 18:48:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHTat-0000S7-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Jan 2023 18:48:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHTaH-0002Mr-Lh; Mon, 16 Jan 2023 12:47:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHTZg-0001Yc-L4 for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2023 12:47:17 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHTZW-0006wF-Ev for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2023 12:47:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHTZW-0008K3-Az for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2023 12:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jan 2023 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60285 X-GNU-PR-Package: emacs Original-Received: via spool by 60285-submit@debbugs.gnu.org id=B60285.167389118231922 (code B ref 60285); Mon, 16 Jan 2023 17:47:02 +0000 Original-Received: (at 60285) by debbugs.gnu.org; 16 Jan 2023 17:46:22 +0000 Original-Received: from localhost ([127.0.0.1]:34640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHTYr-0008Io-T8 for submit@debbugs.gnu.org; Mon, 16 Jan 2023 12:46:22 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:48091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHTYq-0008IK-6g for 60285@debbugs.gnu.org; Mon, 16 Jan 2023 12:46:20 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7CAD3240007; Mon, 16 Jan 2023 17:46:11 +0000 (UTC) In-Reply-To: <5ada9b8c-8ec6-d31c-8133-462a577727ad@yandex.ru> (Dmitry Gutov's message of "Mon, 16 Jan 2023 03:41:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253509 Archived-At: >> Indeed, there is a special hook for such cases: >> 'replace-update-post-hook'. > > That one seems problematic. First of all, I think (?) that we need to > update the arrow's position when the replacement prompt appears, not after > a replacement. Maybe another pre-hook is needed that will run before the prompt? > Second, it fires in all cases -- whether the replacement is going forward, > or it being undone, is that right? I suppose this will mean we'll need to > maintain a reverse mapping: from the markers back to the Xref buffer > lines. Hopefully they will be in expected position after the "undo" actions > too. This needs more experimentation to see how it works.