From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#61340: 29.0.60; Extra space in xref buffer Date: Wed, 08 Feb 2023 20:51:12 +0200 Organization: LINKOV.NET Message-ID: <86r0v080cf.fsf@mail.linkov.net> References: <868rh9zzws.fsf@mail.linkov.net> <6a7e3db4-bc2b-2742-bc6c-ad9da8203b85@yandex.ru> <86r0v0zk1o.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38232"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 61340@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 08 20:00:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPpg3-0009iQ-1b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Feb 2023 20:00:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPpfp-0002lQ-HA; Wed, 08 Feb 2023 14:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPpfo-0002hR-3u for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 14:00:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPpfn-0000r0-Ls for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 14:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPpfn-0000cu-1D for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2023 14:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2023 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61340 X-GNU-PR-Package: emacs Original-Received: via spool by 61340-submit@debbugs.gnu.org id=B61340.16758827872353 (code B ref 61340); Wed, 08 Feb 2023 19:00:02 +0000 Original-Received: (at 61340) by debbugs.gnu.org; 8 Feb 2023 18:59:47 +0000 Original-Received: from localhost ([127.0.0.1]:56661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPpfX-0000bt-5A for submit@debbugs.gnu.org; Wed, 08 Feb 2023 13:59:47 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:35801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPpfU-0000bd-Lv for 61340@debbugs.gnu.org; Wed, 08 Feb 2023 13:59:45 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6153CE0008; Wed, 8 Feb 2023 18:59:34 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Wed, 8 Feb 2023 17:14:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255158 Archived-At: >>> This was originally an effort to give the outputted text some "breathing >>> room", and I think it looks a little better. >> Indeed, it looks better but unfortunately at the cost of caused ambiguity. >> I guess this is the reason why Grep and Occur don't add space. > > I suppose we could try to tone down the colon. Occur uses 'shadow' for both > the number and the colon; Grep uses the color from 'default' (with an > underline). > > If we fontify it with 'shadow' rather than 'xref-line-number', that might > look a little better. I already forgot that the default color is too glaring since I customized it long ago to '(xref-line-number ((t (:inherit shadow)))). But I also customized other xref faces e.g. '(xref-file-header ((t (:extend t :background "grey90")))), so these faces provide a better look. OTOH, I'm not sure if the default of xref-line-number can be changed because on the one hand the purple color from compilation-line-number is needed in grep to make them more noticeable because the line numbers are in the middle of the line unlike in occur. But on the other hand the current theme of xref buffers matches all colors of grep, so any change will make their default themes different.